Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Two shot pipeline #184

Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

[DRAFT] Two shot pipeline #184

wants to merge 66 commits into from

Conversation

MinhxNguyen7
Copy link
Contributor

@MinhxNguyen7 MinhxNguyen7 commented May 1, 2024

Summary

  • Implement the new two-shot pipeline, where the first shot gives bounding boxes, and the second gives (all) classifications.
    • The first shot is YOLO detection on the "target" class, encompassing all shapes.
    • The second shot is a custom classifier.
  • Extracts YoloDetector base class for use in old ShapeDetector (should we want to go back) and OneDetector (new).

TODOs

Test Plan

  • Run the image processor tests on main and this pipeline to confirm that they have the same failures and errors.

Issues

Future Follow-Up

  • Consider filtering out targets that have low classification confidences.
  • If non-max suppression can take a generic iterable instead of a list, we can stream the whole pipeline, which should optimize memory usage and even inference time. @SuvirBajaj is this possible?
    • Answer: No

@MinhxNguyen7
Copy link
Contributor Author

@EricPedley Everything is done and works, but the YOLO detector trained on Isaac data is ass, so you can't tell the performance of classification. I anticipate that we won't have time to train it to be better than what we had, so we should just stick with that. However, according to PyTorch, the weights on my PC are corrupted, so I can't even load the old model. Do you mind running the tests on your machine? With the OneDetector, all the relevant tests pass on my PC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two-shot pipeline
2 participants