Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: adds aXe test for <Officers />; resolves key bug #507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattxwang
Copy link
Contributor

Followup to #412, gradually increasing coverage.

Two small notes:

  1. You need to mock next/image somehow. This trivial mock is from How to use next/image Image component in Storybook or Jest? vercel/next.js#18516, however I think after you upgrade to Next 12 it becomes easier.
  2. There's a current bug in Officers that incorrectly uses a non-existent field as the key. Updated to use an existing field.

@mattxwang
Copy link
Contributor Author

Just going through my own stale PRs, bump @matthewcn56.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant