Skip to content

impact site update#783

Closed
RohanAdwankar wants to merge 23 commits intouclaacm:mainfrom
RohanAdwankar:main
Closed

impact site update#783
RohanAdwankar wants to merge 23 commits intouclaacm:mainfrom
RohanAdwankar:main

Conversation

@RohanAdwankar
Copy link
Copy Markdown
Contributor

issue#780
it has some changes we wanted involving adding our ig feed, a carousel, etc
it would be great if we could get some help for merging this in!
thanks!

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2025

👷 Deploy request for jovial-pasteur-581b4a accepted.

Name Link
🔨 Latest commit 7bd39f7
🔍 Latest deploy log https://app.netlify.com/sites/jovial-pasteur-581b4a/deploys/67fc72447649690008f827ff

@smalex-z
Copy link
Copy Markdown
Contributor

Hi Rohan!

Thanks for the PR- We're currently in the midst of recruitment so I won't have time to fully analyze this PR until later next week, but a few things to tackle beforehand-

The deploy check is currently failing due to a bad google drive link that still matches our regex expression somewhere in the ACM Directory. This should be fixed in PR #784 , Feel free to pull that branch into yours and see whether that fixes the deploy checks failing.

Also, please take a minute to review and fix the ESLint errors. It tends to be rather picky about whitespace and trailing spaces, which tend to be the bulk of the warnings. There were a command to test ESLint compliance and one to try and automatically fix it, but I can't seem to remember it off the top of my head 😅. I'll send you a message if I remember the exact command.

@smalex-z smalex-z requested review from smalex-z and removed request for smalex-z April 14, 2025 08:06
@smalex-z smalex-z mentioned this pull request Apr 29, 2025
3 tasks
@smalex-z
Copy link
Copy Markdown
Contributor

PR Moved to #791

@smalex-z smalex-z closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants