Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delly v1.2.8 #27

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Delly v1.2.8 #27

merged 3 commits into from
Sep 25, 2024

Conversation

Faizal-Eeman
Copy link
Contributor

@Faizal-Eeman Faizal-Eeman commented Sep 24, 2024

Description

Update Delly v1.2.6 to v1.2.8.

Closes #26

Testing Results

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

Test the Docker image with at least one sample. Verify the new Docker image works using:

docker run -u $(id -u):$(id -g) –w <working-directory> -v <directory-you-want-to-mount>:<how-you-want-to-mount-it-within-the-docker> --rm <docker-image-name> <command-to-the-docker-with-all-parameters>

My command:

docker build --no-cache --progress=plain -t delly:1.2.8 . &> build.log

docker run -it --rm -u $(id -u):$(id -g) delly:1.2.8 bash
$ delly --version
Delly version: v1.2.8
 using Boost: v1.85.0
 using HTSlib: v1.21

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number in the Dockerfile, README.md and metadata.yaml files.

  • I have updated the dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the feature changes in the README.md (optional).

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

GitHub Packages Auto Build Rules

  • I have not manually pushed this Docker image to the uclahs-cds container registry (ghcr.io/uclahs-cds) on GitHub.

  • I have updated the image_name in the metadata.yaml which is required by GitHub action to automatically build and push the image.

@Faizal-Eeman
Copy link
Contributor Author

Build log - /hot/software/image/docker-Delly/Docker/development/1.2.8/build_v1.2.8.log

Copy link

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Faizal-Eeman Faizal-Eeman merged commit e183f00 into main Sep 25, 2024
6 checks passed
@Faizal-Eeman Faizal-Eeman deleted the mmootor-delly-1-2-8 branch September 25, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DELLY v1.2.8
2 participants