Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Picard version to 3.1.1 #34

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

j2salmingo
Copy link
Contributor

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number/dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the version number/feature changes in the README.md.

  • I have updated the version number and added my name to the contributors list in the metadata.yaml.

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have drafted the new version release with any additions/changes and have linked the CHANGELOG.md in the release.

Docker Hub Auto Build Rules

  • I have created automated build rules following this page and I have not manually pushed this Docker image to the blcdsdockerregistry on Docker Hub.

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

Test the Docker image with at least one sample. Verify the new Docker image works using:

docker run -u $(id -u):$(id -g) –w <working-directory> -v <directory-you-want-to-mount>:<how-you-want-to-mount-it-within-the-docker> --rm <docker-image-name> <command-to-the-docker-with-all-parameters>

My command:

docker run -u $(id -u):$(id -g) -it --rm picard311 picard SortSam --version
/usr/local/bin/picard: line 5: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory
Version:3.1.1
docker run -u $(id -u):$(id -g) -v $(pwd):/home -it --rm picard311 picard ValidateSamFile -I /home/HG002.N-n2.bam
/usr/local/bin/picard: line 5: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory
Nov 15, 2023 8:53:41 PM com.intel.gkl.NativeLibraryLoader load
INFO: Loading libgkl_compression.so from jar:file:/usr/local/share/picard-slim-3.1.1-0/picard.jar!/com/intel/gkl/native/libgkl_compression.so
[Wed Nov 15 20:53:42 GMT 2023] ValidateSamFile --INPUT /home/HG002.N-n2-adjust.bam --MODE VERBOSE --MAX_OUTPUT 100 --IGNORE_WARNINGS false --VALIDATE_INDEX true --INDEX_VALIDATION_STRINGENCY EXHAUSTIVE --IS_BISULFITE_SEQUENCED false --MAX_OPEN_TEMP_FILES 8000 --SKIP_MATE_VALIDATION false --VERBOSITY INFO --QUIET false --VALIDATION_STRINGENCY STRICT --COMPRESSION_LEVEL 5 --MAX_RECORDS_IN_RAM 500000 --CREATE_INDEX false --CREATE_MD5_FILE false --help false --version false --showHidden false --USE_JDK_DEFLATER false --USE_JDK_INFLATER false
[Wed Nov 15 20:53:42 GMT 2023] Executing as ?@ac26099c947a on Linux 3.10.0-1160.92.1.el7.x86_64 amd64; OpenJDK 64-Bit Server VM 21.0.1-internal-adhoc.conda.src; Deflater: Intel; Inflater: Intel; Provider GCS is available; Picard version: Version:3.1.1
WARNING 2023-11-15 20:53:42 ValidateSamFile NM validation cannot be performed without the reference. All other validations will still occur.
No errors found
[Wed Nov 15 20:53:44 GMT 2023] picard.sam.ValidateSamFile done. Elapsed time: 0.04 minutes.
Runtime.totalMemory()=538968064

Description

Updates Picard to v3.1.1
Closes #33

@j2salmingo j2salmingo self-assigned this Nov 15, 2023
Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We can go ahead and make a release for 3.1.1

@nwiltsie
Copy link
Member

@yashpatel6 should we push this release through?

@yashpatel6
Copy link
Contributor

We should, I'll merge this if you want to make a release afterwards

@yashpatel6 yashpatel6 merged commit 6319124 into main Mar 27, 2024
1 check passed
@yashpatel6 yashpatel6 deleted the jsalmingo-update-picard-to-311 branch March 27, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picard 3.1.1
3 participants