Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hwinata add documentation #129

Merged
merged 14 commits into from
Jul 30, 2024
Merged

Hwinata add documentation #129

merged 14 commits into from
Jul 30, 2024

Conversation

whelena
Copy link
Collaborator

@whelena whelena commented Jun 5, 2024

Description

Provide documentatio for heatmaps and clone genome distribution plot

Checklist

  • This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
    Disclosing PHI is a major problem1 - Even a small leak can be costly2.

  • This PR does NOT contain germline genetic data3, RNA-Seq, DNA methylation, microbiome or other molecular data4.

  • This PR does NOT contain other non-plain text files, such as: compressed files, images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other output files.

  To automatically exclude such files using a .gitignore file, see here for example.

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

Footnotes

  1. UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records

  2. The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records.

  3. Genetic information is considered PHI.
    Forensic assays can identify patients with as few as 21 SNPs

  4. RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity.

@whelena whelena requested a review from dan-knight June 14, 2024 19:56
@whelena
Copy link
Collaborator Author

whelena commented Jun 20, 2024

My R CMD check is blocked by this note:

  Skipping checking HTML validation: no command 'tidy' found

Any idea what caused this @dan-knight ?

@dan-knight
Copy link
Collaborator

dan-knight commented Jul 24, 2024

My R CMD check is blocked by this note:

  Skipping checking HTML validation: no command 'tidy' found

This isn't actually blocking it. There are two documentation warnings caused by ...:

checking for code/documentation mismatches ... WARNING
checking Rd \usage sections ... WARNING

@whelena
Copy link
Collaborator Author

whelena commented Jul 24, 2024

My R CMD check is blocked by this note:

  Skipping checking HTML validation: no command 'tidy' found

This isn't actually blocking it. There are two documentation warnings caused by ...:

checking for code/documentation mismatches ... WARNING
checking Rd \usage sections ... WARNING

Yes I did end up tracing it there and I have tried different ways of documenting it. I referred to BPG's documentation, which seems to pass the same tests and uses ... as well.

@dan-knight
Copy link
Collaborator

I referred to BPG's documentation, which seems to pass the same tests and uses ... as well.

Yeah, that's strange. I'm looking into it. We should be able to fix that and get this check to pass.

@dan-knight
Copy link
Collaborator

Fixed the errors. When using ..., you should:

  1. Document it explicitly as a parameter
  2. Include it in the usage section
  3. Write usage as if you were calling the function.

Usage should be formatted as follows:

\usage{
example.function(
    arg1,
    arg2 = NULL,
    ...
    );
}

Notice that this is not written as if the function were being declared. So, don't write it as example.function <- function(arg1, arg2 = NULL);.

@dan-knight dan-knight merged commit a3386ac into main Jul 30, 2024
6 checks passed
@dan-knight dan-knight deleted the hwinata-add-documentation branch July 30, 2024 19:34
@whelena
Copy link
Collaborator Author

whelena commented Jul 30, 2024

Thank you!! I don't know how I missed that but I'm glad its figured out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants