Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend edge style functionality #82

Merged
merged 37 commits into from
Nov 15, 2023
Merged

Extend edge style functionality #82

merged 37 commits into from
Nov 15, 2023

Conversation

dan-knight
Copy link
Collaborator

@dan-knight dan-knight commented Aug 2, 2023

Description

Closes #98, #99, #100, #104.
New columns in tree input:

Style Column
Node Colour node.col
Node Label Colour node.label.col
Node Border Colour border.col
Node Border Width border.width
Node Border Line Type border.type
Edge Colour edge.col.2, edge.col.2
Edge Width edge.width.2, edge.width.2
Edge Line Type edge.type.2, edge.type.2

Removes obsolete seg.col parameters for consistency.

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

@dan-knight dan-knight added the enhancement New feature or request label Aug 2, 2023
This was linked to issues Oct 21, 2023
@dan-knight dan-knight merged commit 4e03d7d into main Nov 15, 2023
2 checks passed
@dan-knight dan-knight deleted the danknight-extend-branches branch November 15, 2023 21:19
@dan-knight dan-knight linked an issue Nov 17, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flexible branch column names Specify edge line type Specify edge colour Specify edge width
2 participants