Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence logging in venn.diagram #25

Open
stefaneng opened this issue Jan 12, 2023 · 1 comment
Open

Silence logging in venn.diagram #25

stefaneng opened this issue Jan 12, 2023 · 1 comment

Comments

@stefaneng
Copy link
Contributor

The default behavior for venn.diagram is to write a log to file. There is an argument disable.logging which prevents logging to file and prints to stdout but no option to silence logging output. It would be nice to have a third option which is no logging output.

Idea solution: Default is silent with no logging, except warning or errors as standard. Opting in to logging is the nicer default for most users and is the standard in plotting packages.

@pboutros
Copy link
Collaborator

I like the idea of overloading the disable.logging argument to allow silent, but I'd prefer to not change the default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants