-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a barplot of the summarizeFasta results #734
Conversation
The example output looks fine. It worries me if "Noncoding" is also plotted cuz then you would literally only be able to see that 1 bar. Maybe it's worth adding a log10 if Noncoding is plotted (and since stacked no longer works just use one colour)? Is the current sorting order the same as in the summarizeFasta text file? |
Log scaling sounds reasonable but it will make the stacked barplot hard to interpret, because the stacked bars are no longer proportional.
They should be in the same order |
Yeah so if we do log scale we can just do a single colour for the bars :) (aka not show the miscleavages) |
I added a pair of argument This is what it looks like. Scale looks strand because it's small. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! The only thing I can think of is whether we should exclude the entries with 0 peptides? I think it's ok eitherway (I don't think we are excluding any now)
Let's leave it in this way for now. Will be good to see some examples. |
Description
The
summarizeFasta
now can accept a--output-image
arg and creates a barplot of the summary results. This is an example:Any thought?
Closes #...
Checklist
.png
, .jpeg
),.pdf
,.RData
,.xlsx
,.doc
,.ppt
, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.CHANGELOG.md
under the next release version or unreleased, and updated the date.