Fix default setting for clean_logs (#38)

* Make default None for clean_logs

* Update CHANGELOG

* Bump version to 1.0.0-rc.3

* Update condition

CHANGELOG.md

@@ -11,6 +11,12 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ---
 
+## [1.0.0-rc.3] - 2023-05-25
+### Fixed
+- Properly set default value of `clean_logs` according to case and global settings
+
+---
+
 ## [1.0.0-rc.2] - 2023-03-09
 ### Added
 - Case name to output directory path to avoid over-writing

nftest/NFTestCase.py

@@ -24,7 +24,7 @@ def __init__(self, name:str=None, message:str=None, nf_script:str=None,
             nf_configs:List[str]=None, profiles:List[str]=None, params_file:str=None,
             output_directory_param_name:str='output_dir',
             asserts:List[NFTestAssert]=None, temp_dir:str=None,
-            remove_temp:bool=None, clean_logs:bool=True,
+            remove_temp:bool=None, clean_logs:bool=None,
             skip:bool=False, verbose:bool=False):
         """ Constructor """
         self._env = NFTestENV()
@@ -136,7 +136,7 @@ def combine_global(self, _global:NFTestGlobal) -> None:
         if not self.temp_dir:
             self.temp_dir = _global.temp_dir
 
-        if not self.clean_logs:
+        if self.clean_logs is None:
             self.clean_logs = _global.clean_logs
 
     def print_prolog(self):

nftest/__init__.py

@@ -1,3 +1,3 @@
 """ nftest module """
 
-__version__ = '1.0.0-rc.2'
+__version__ = '1.0.0-rc.3'