LIBAAEC-33 Modify PR template body and create github actions to add Jira issue

.bundler-audit.yml

@@ -6,5 +6,5 @@ ignore:
   - CVE-2024-53986
   - CVE-2024-53985
 
-  #  actionpack - needs Rails 7 upgrade to fix
+    #  actionpack - needs Rails 7 upgrade to fix
   - CVE-2024-54133

.github/workflows/update-pr.yml

@@ -0,0 +1,15 @@
+name: Update PR with Jira Issue
+on:
+  pull_request:
+    types: [opened, edited, synchronize, reopened]
+
+jobs:
+  update-pr:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Update PR with Jira Issue
+        uses: uclibs/jira-pr-updater-action@v1
+        with:
+          jira-base-url: 'https://ucdts.atlassian.net'
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.ruby-gemset

@@ -1 +1 @@
--global
+-global

Gemfile.lock

@@ -206,27 +206,19 @@ GEM
       net-protocol
     net-ssh (7.3.0)
     nio4r (2.7.4)
-    nokogiri (1.18.1)
-      mini_portile2 (~> 2.8.2)
+    nokogiri (1.16.7-aarch64-linux)
       racc (~> 1.4)
-    nokogiri (1.18.1-aarch64-linux-gnu)
+    nokogiri (1.16.7-arm-linux)
       racc (~> 1.4)
-    nokogiri (1.18.1-aarch64-linux-musl)
-      racc (~> 1.4)
-    nokogiri (1.18.1-arm-linux-gnu)
-      racc (~> 1.4)
-    nokogiri (1.18.1-arm-linux-musl)
-      racc (~> 1.4)
-    nokogiri (1.18.1-arm64-darwin)
-      racc (~> 1.4)
-    nokogiri (1.18.1-x86_64-darwin)
-      racc (~> 1.4)
-    nokogiri (1.18.1-x86_64-linux-gnu)
+    nokogiri (1.16.7-arm64-darwin)
+    nokogiri (1.16.7-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.1-x86_64-linux-musl)
+    nokogiri (1.16.7-x86-linux)
       racc (~> 1.4)
     nokogiri (1.16.7-x86_64-darwin)
       racc (~> 1.4)
+    nokogiri (1.16.7-x86_64-linux)
+      racc (~> 1.4)
     ostruct (0.6.1)
     pagy (9.3.1)
     parallel (1.26.3)
@@ -300,17 +292,17 @@ GEM
     rspec-support (3.13.1)
     rspec_junit_formatter (0.6.0)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (1.67.0)
+    rubocop (1.69.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.4, < 3.0)
-      rubocop-ast (>= 1.32.2, < 2.0)
+      rubocop-ast (>= 1.36.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.32.3)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.36.2)
       parser (>= 3.3.1.0)
     ruby-progressbar (1.13.0)
     rubyzip (2.3.2)
@@ -324,7 +316,7 @@ GEM
       sprockets (> 3.0)
       sprockets-rails
       tilt
-    selenium-webdriver (4.25.0)
+    selenium-webdriver (4.27.0)
       base64 (~> 0.2)
       logger (~> 1.4)
       rexml (~> 3.2, >= 3.2.5)
@@ -378,7 +370,9 @@ GEM
       concurrent-ruby (~> 1.0)
     uglifier (4.2.1)
       execjs (>= 0.3.0, < 3)
-    unicode-display_width (2.6.0)
+    unicode-display_width (3.1.2)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
     web-console (4.2.1)
       actionview (>= 6.0.0)
       activemodel (>= 6.0.0)

config/brakeman.ignore

@@ -7,7 +7,7 @@
       "check_name": "EOLRails",
       "message": "Support for Rails 6.1.7.10 ended on 2024-10-01",
       "file": "Gemfile.lock",
-      "line": 213,
+      "line": 233,
       "link": "https://brakemanscanner.org/docs/warning_types/unmaintained_dependency/",
       "code": null,
       "render_path": null,

spec/features/publication_creation/other_college_field_manipulation_spec.rb

@@ -18,9 +18,13 @@
 
     it 'selects an already listed college' do
       within '#colleges-group' do
-        all('input[type="checkbox"]')[1].set(true) # Array is zero-indexed
+        # Find and explicitly check the second checkbox
+        checkbox = all('input[type="checkbox"]')[1]
+        checkbox.set(true)
+
+        # Explicitly wait for the checkbox to be checked
+        expect(checkbox).to be_checked
       end
-      expect(page).to have_selector('input[type="checkbox"]:checked', count: 1)
       click_on('Submit')
 
       expect(page).to have_current_path(Rails.application.routes.url_helpers.publications_path)
@@ -32,33 +36,34 @@
     context 'When selecting Other college' do
       it 'toggles the Other College text field' do
         other_checkbox = all('input[type="checkbox"]').last
-        other_college_field = find('#other_college_group', visible: :all) # Finds even if invisible
 
         # Initially, the Other College field should not be visible
-        expect(other_college_field).not_to be_visible
+        expect(page).to have_selector('#other_college_group', visible: false)
 
         # Select the Other checkbox
         other_checkbox.set(true)
 
         # Now, the Other College field should be visible
-        expect(page).to have_selector('input[type="checkbox"]:checked', count: 1)
-        expect(page).to have_text('Other College')
-        expect(other_college_field).to be_visible
+        expect(page).to have_selector('#other_college_group', visible: true)
 
         # Unselect the Other checkbox
         other_checkbox.set(false)
 
         # The Other College field should not be visible again
-        expect(other_college_field).not_to be_visible
+        expect(page).to have_selector('#other_college_group', visible: false)
       end
 
       it 'allows user to select Other college without filling in the Other name' do
         # The "Other" college is the last checkbox in the Colleges group
         within '#colleges-group' do
-          all('input[type="checkbox"]').last.set(true)
+          # Find and explicitly check the last checkbox
+          checkbox = all('input[type="checkbox"]').last
+          checkbox.set(true)
+
+          # Explicitly wait for the last checkbox to be checked
+          expect(checkbox).to be_checked
         end
 
-        expect(page).to have_selector('input[type="checkbox"]:checked', count: 1)
         click_on('Submit')
 
         expect(page).to have_current_path(Rails.application.routes.url_helpers.publications_path)
@@ -111,9 +116,22 @@
 
       it 'saves both a listed college and Other college when selected' do
         within '#colleges-group' do
-          all('input[type="checkbox"]')[1].set(true) # Array is zero-indexed
-          all('input[type="checkbox"]').last.set(true)
+          # Select the second checkbox and set it to true
+          checkbox1 = all('input[type="checkbox"]')[1]
+          checkbox1.set(true)
+
+          # Explicitly wait for the checkbox to be checked
+          expect(checkbox1).to be_checked
+
+          # Select the last checkbox and set it to true
+          checkbox2 = all('input[type="checkbox"]').last
+          checkbox2.set(true)
+
+          # Explicitly wait for the last checkbox to be checked
+          expect(checkbox2).to be_checked
         end
+
+        # Ensure there are exactly 2 checkboxes checked
         expect(page).to have_selector('input[type="checkbox"]:checked', count: 2)
         fill_in('artwork[other_college]', with: 'Other College Name')
         click_on('Submit')