Apply Python 3 changes to grid_openid allowing test instantiation. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
albu-diku
force-pushed
the
test/grid_openid-py3
branch
from
7a2fce1 to
e781a7a
Compare
albu-diku
changed the title
jonasbardino
approved these changes
Aug 20, 2024
jonasbardino
added
enhancement
|
Added the OpenID Connect milestone because unit test coverage of the old OpenID 2.0 service is important in the development of the replacement. |
Thanks - that was definitely the reason to do this, and I remember mentionig directly, but doing this predated the tracking issue hence not being listed there already. No time like the present to start and appreciate your adding it. |
albu-diku
changed the base branch from
test/enforce-clean-error-log-and-add-after_each
to
edge
albu-diku
force-pushed
the
test/grid_openid-py3
branch
2 times, most recently
from
4a54200 to
e9516e6
Compare
albu-diku
changed the base branch from
edge
to
refactor/split-up-test-support-library
albu-diku
changed the base branch from
refactor/split-up-test-support-library
to
test/server-support
albu-diku
force-pushed
the
test/grid_openid-py3
branch
from
4cc3bb9 to
68f7a7c
Compare
albu-diku
force-pushed
the
test/grid_openid-py3
branch
from
68f7a7c to
8c65420
Compare
Make use of a need to cover the basic operation of this code for some minimal changes that allow the server it implements to be trivial to instantiate directly as an object. Use this ability to do so under test and add the necessary wiring to issue a single top-level request from the server and validate it responds with no internal issues logged. Note that a top-level request was not previously succeedding due to certain values being errantly dereferenced (though the code was clearly written to have been safe under these circumstances). Fix this here. --- align requirements with extant reality ensure server is closed between tests and validate with a status 404 case pull the test synchronisation up a level thus out of the server logic ensure the server is fully managed inside test case arranged thread improve naming make the class configurable an extend documentation inline escape_hmtl fixup fixup fixup fixup remove unnecessary version swizzle make use of the same Py3 compatible openid library as rocky 9 fixup
albu-diku
force-pushed
the
test/grid_openid-py3
branch
from
8c65420 to
a45e92a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of a need to cover the basic operation of this code for some
minimal changes that allow the server it implements to be trivial to
instantiate directly as an object. Use this ability to do so under test
and add the necessary wiring to issue a single top-level request from
the server and validate it responds with no internal issues logged.
Note that a top-level request was not previously succeeding due to
certain values being errantly dereferenced (though the code was clearly
written to have been safe under these circumstances). Fix this here.