Changes corresponding to an implementation of a core api. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albu-diku
force-pushed
the
addition/core-api
branch
2 times, most recently
from
267875b to
067b2c2
Compare
albu-diku
force-pushed
the
addition/core-api
branch
3 times, most recently
from
85f9adb to
2eb2c72
Compare
albu-diku
force-pushed
the
addition/core-api
branch
4 times, most recently
from
42cc644 to
a9bea6f
Compare
albu-diku
force-pushed
the
addition/core-api
branch
4 times, most recently
from
32c2b91 to
9875abb
Compare
albu-diku
force-pushed
the
addition/core-api
branch
from
9875abb to
3641796
Compare
Add the logic to automatically package values as a bundle. Implement declarative argument definitions and logic to bundle values. carve out payloads and rework them to make use of the validation helper Expand the arguments module with the notions of a defined grouping of arguments (ArgumentBundleDefinition) and bundles of particular arguments (ArgumentBundle). Use this as the mechanism by which payloads are checked for validity. As part of declaring a bundle definition the expected positional arguments are declared so implement basic length checks that catch missing positional arguments which were required. Each argument itself is also tested aganst an optional validity function which can be specified at the point of definition. try to combine payloads with the argument stuff move the test further re-integration match the other branch fixup fixup fixup repair and test error conditions fixup fixup fixup quack like a named tuple raise uniform payload exceptions and properly handle dictionaries
Do the core work necessary to have a first response served to a GET request and some basic wiring to allow submission of JSON via POST. CHECKPOINT: running coreapi server overrides? not yet sure why this was needed Implement a user creation endpoint in the server. Back a POST handler onto the refactored createuser functionality file which exposes a function that can be invoked programatically with a configuration. Split out the response data decoding chunk. axe depedency pn reworkings on userapi fixups - move closer to the server working without createuser changes Implement finding users by email address. relocate fixup carve out payloads and rework them to make use of the validation helper shut up flake complaints about things that have changed further fixup another
albu-diku
force-pushed
the
addition/core-api
branch
from
08dd5ec to
f093e2f
Compare
albu-diku
force-pushed
the
addition/core-api
branch
from
f284ab9 to
811b340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.