-
Notifications
You must be signed in to change notification settings - Fork 4
Adjust/remove deprecated image preview #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -961,7 +961,6 @@ Alias /status-events.json "/home/mig/state/wwwpublic/status-events.json" | |||
RewriteCond %{REQUEST_URI} ^/favicon.ico$ [OR] | |||
RewriteCond %{REQUEST_URI} ^/(images|assets|public|.well-known)/ [OR] | |||
RewriteCond %{REQUEST_URI} ^/(seafmedia|seafhttp|seafile)/ [OR] | |||
RewriteCond %{REQUEST_URI} ^/paraview/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder that this fixture file needs all the same updates after fixing the [OR]
issue above in the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and ready for merge as soon as the RewriteCondition
comment issue is handled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost complete, but the fixtures MiG.conf
file still needs to be updated accordingly as the continuous integration checks point out. Feel free to merge once resolved.
Remove deprecated and non-maintained image preview functionality along with it's helper modules