Cleanup for overridden notations #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DmxLarchey#16 corrects scoping issues in the |
|
The CI currently fails because |
…rary-undecidability into notation-overridden-2
|
@dominik-kirst Could you please have a look at the proposed changes. They are all in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #231. It intends to solve remaining issues related to overridden notations, ie warnings that pop up when compiling without the flag
-notation-overridden. @dominik-kirst would you mind having a look? Orelse pinging the author of the corresponding files? I also ping @mrhaandi who initiated those warning issues in themasterbranch.Notice that this branch is supposed to be compiled with
rocq, notcoq.The concerned files are below.
Proposed solutions by @DmxLarchey :
FOL/FOL.v;FOL/Utils/FriedmanTranslation.v;FOL/Utils/FriedmanTranslationFragment.v;FOL/Reductions/H10p_to_FA.v.Proposed solutions by @mrhaandi :
FOL/binFST_undec.v;FOL/Semantics/FiniteTarski/DoubleNegation.v;FOL/Reductions/H10UPC_to_FOL_friedman.v;FOL/Reductions/binZF_to_binFST.v;FOL/Reductions/ZF_to_FST.v.