fix: missing package and wrong svelte code #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package @tiptap/extension-bubble-menu was missing in the instructions but used in the example. Also, the code was missing the opening script tag and the onMount import. I also moved the onDestroy to the return function of the onMount since it does the same. I would also recommend for the future to use a `<script lang="ts">` tag and write it in TypeScript.
|
@ImGajeed76 is attempting to deploy a commit to the Tiptap Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package
@tiptap/extension-bubble-menuwas missing in the instructions but used in the example.Also, the code was missing the opening script tag and the onMount import. I also moved the onDestroy to the return function of the onMount since it does the same.
I would also recommend for the future to use a
<script lang="ts">tag and write it in TypeScript.(Also, I'm sorry that I use 4 spaces instead of 2... I just quickly did this on GitHub. 💀)