Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a copy with method to FeedbackThemeData #312

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Add a copy with method to FeedbackThemeData #312

merged 4 commits into from
Jun 5, 2024

Conversation

ricardoboss
Copy link
Contributor

@ricardoboss ricardoboss commented May 28, 2024 •
edited
Loading

📜 Description

Adds a copyWith method to FeedbackThemeData. Also adds brightness as a settable property.

💡 Motivation and Context

This fixes issue #311.

💚 How did you test it?

By calling copyWith in the example and seeing its results.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@ricardoboss ricardoboss requested a review from ueman as a code owner May 28, 2024 13:02
ueman
ueman reviewed May 29, 2024
View reviewed changes
feedback/lib/src/theme/feedback_theme.dart

/// Creates a copy of the current [FeedbackThemeData] with the given
/// optional fields replaced with the given values.
FeedbackThemeData copyWith({
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll look into it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ueman done

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ueman
ueman reviewed May 29, 2024
View reviewed changes
Copy link
Owner

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, thanks!

@ueman ueman merged commit e4f8a8f into ueman:master Jun 5, 2024
2 of 3 checks passed
@ricardoboss ricardoboss deleted the issues/311-theme-copy-with branch June 5, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueman ueman ueman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardoboss @ueman