-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a copy with method to FeedbackThemeData #312
Conversation
|
||
/// Creates a copy of the current [FeedbackThemeData] with the given | ||
/// optional fields replaced with the given values. | ||
FeedbackThemeData copyWith({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ueman done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, thanks!
📜 Description
Adds a
copyWith
method toFeedbackThemeData
. Also addsbrightness
as a settable property.💡 Motivation and Context
This fixes issue #311.
💚 How did you test it?
By calling
copyWith
in the example and seeing its results.📝 Checklist
🔮 Next steps