Skip to content

Timeline - #31

Merged
jordanbrotherton merged 12 commits into
ufosc:mainfrom
BBlaza:Time_Line
May 23, 2026
Merged

Timeline#31
jordanbrotherton merged 12 commits into
ufosc:mainfrom
BBlaza:Time_Line

Conversation

@BBlaza

@BBlaza BBlaza commented May 10, 2026

Copy link
Copy Markdown
Contributor

Finished the basic setup of the timeline, completed the following features:

Display each frame in order
Allow the user to make a selection of layers in the timeline

The lower half of the timeline panel is left for the audio timeline

All the features have been implemented. This Pr should implement the following feature requests:
#4
#23

BBlaza added 6 commits May 9, 2026 21:29
Finished the basic setup of the timeline, completed the following features:

Display each frame in order
Allow the user to make a selection of layers in the timeline

The lower half of the timeline panel is leave for the audio timeline

The features of the timeline are not fully completed yet; features under development:
1. copy layer
2. delete layer
3. add layer
Now each page can have multiple layers
@BBlaza
BBlaza marked this pull request as ready for review May 17, 2026 23:50
@jordanbrotherton

Copy link
Copy Markdown
Collaborator

Really good work here! In my testing and review most of all seems good. There are however some blockers that need to be addressed:

  • I noticed you added an index to the create_layer method, and when you call it in the timeline_manager.gd file, you did not specify a color. Passing TRANSPARENT before the index should fix this.
  • The timeline is completely empty when you load an existing project, only when you add a new page will the timeline appear. It seems calling setup_image_timeline() when you attach a valid project fixes this issue.
  • Slightly more minor but I noticed that GUT was modified by a formatter, please revert that change to avoid conflicts.

Once these issues are addressed, it should be good to merge! Once again, really good PR!

BBlaza added 5 commits May 22, 2026 15:45
@BBlaza

BBlaza commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

@jordanbrotherton All done! Should be ready to be merged.

@jordanbrotherton

Copy link
Copy Markdown
Collaborator

Looks good, merged!

@jordanbrotherton
jordanbrotherton merged commit d5feeb2 into ufosc:main May 23, 2026
1 check passed
This was referenced Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants