Frontend CSS Cleanup - #102
Merged
Merged
Conversation
This commit ran `npm audit fix` to fix security vulnerabilities.
I am using a Vite extension on VSCode that requires usePolling in the Vite config. This commit adds the .vite/ directory that was spawned and that configuration change.
The buttons in our app weren't accounting for the size of the border hovers. This made the entire application's frontend shake when a button was hovered over. This commit addresses that by adding a `studygatchi-button` class to App.css and applies that to most buttons in the frontend. Further revision may end up overriding the default button CSS instead of creating a new class. This commit also fixes the issue of Goober's window not being centered.
This commit primarily adds the food menu. It still needs some cleanup, mainly on the layout, but it looks passable enough to commit. This commit also updates the image of Goober to be an asset created by Kaydence, so it makes the frontend look significantly more professional. There's a placeholder background as well.
Collaborator
|
Since this is a frontend change, please add a screenshot showing off the visual changes you made! |
Collaborator
Author
|
Ah, my mistake, I forgot. I'll take a look later |
anthisse
marked this pull request as ready for review
September 1, 2026 16:39
Open
This commit changes some layout for the food menu and clarifies some function names.
Collaborator
Author
@fmcubium Sorry that this took a little while, I got busy with other work. |
This commit fixes the jittering buttons by updating a good amount of the CSS to use "outline" instead of "border" since that doesn't interact with the box model.
Collaborator
Author
|
In regards to the jittering buttons, we could also change back to border and reserve the space between with a transparent border first with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to get our frontend to be easier to work with by new maintainers. I'm trying to make the layout similar to what is seen in the Figma by @anthonyle1. I'm not going to be drawing any assets for this PR; those should be made in a different PR.