Add Wesely and Zhang dry dep schemes #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
note this should go in after #111 |
bbakernoaa
commented
Feb 28, 2025
bbakernoaa
commented
Feb 28, 2025
bbakernoaa
commented
Feb 28, 2025
There was a problem hiding this comment.
Copilot reviewed 11 out of 27 changed files in this pull request and generated no comments.
Files not reviewed (16)
- .codespellrc: Language not supported
- src/api/CMakeLists.txt: Language not supported
- src/api/catchem.F90: Language not supported
- src/core/chemstate_mod.F90: Language not supported
- src/core/config_mod.F90: Language not supported
- src/core/config_opt_mod.F90: Language not supported
- src/core/diagstate_mod.F90: Language not supported
- src/core/metstate_mod.F90: Language not supported
- src/core/species_mod.F90: Language not supported
- src/process/CMakeLists.txt: Language not supported
- src/process/bvoc/CMakeLists.txt: Language not supported
- src/process/drydep/CCPr_DryDep_Mod.F90: Language not supported
- src/process/drydep/CMakeLists.txt: Language not supported
- src/process/drydep/ccpr_scheme_Wesely_mod.F90: Language not supported
- src/process/drydep/ccpr_scheme_Zhang_aerosol_mod.F90: Language not supported
- tests/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
tests/Configs/Default/CATChem_config.yml:48
- [nitpick] Consider renaming 'aero_scheme_opt' to 'drydep_aero_scheme_opt' for improved clarity about its association with the dry deposition configuration.
aero_scheme_opt: 1
There was a problem hiding this comment.
Copilot reviewed 11 out of 27 changed files in this pull request and generated 1 comment.
Files not reviewed (16)
- .codespellrc: Language not supported
- src/api/CMakeLists.txt: Language not supported
- src/api/catchem.F90: Language not supported
- src/core/chemstate_mod.F90: Language not supported
- src/core/config_mod.F90: Language not supported
- src/core/config_opt_mod.F90: Language not supported
- src/core/diagstate_mod.F90: Language not supported
- src/core/metstate_mod.F90: Language not supported
- src/core/species_mod.F90: Language not supported
- src/process/CMakeLists.txt: Language not supported
- src/process/bvoc/CMakeLists.txt: Language not supported
- src/process/drydep/CCPr_DryDep_Mod.F90: Language not supported
- src/process/drydep/CMakeLists.txt: Language not supported
- src/process/drydep/ccpr_scheme_Wesely_mod.F90: Language not supported
- src/process/drydep/ccpr_scheme_Zhang_aerosol_mod.F90: Language not supported
- tests/CMakeLists.txt: Language not supported
| scheme_opt: 1 | ||
| aero_scheme_opt: 1 | ||
| resuspension: false | ||
| #CO2 effect on stomatal conductance in wesely |
There was a problem hiding this comment.
[nitpick] Consider capitalizing 'wesely' to 'Wesely' for consistency with the PR title and documentation.
Suggested change
| #CO2 effect on stomatal conductance in wesely | |
| #CO2 effect on stomatal conductance in Wesely |
bbakernoaa
added this to the
01) Connect second version of CATChem (GOCART-2G aerosols) to the official UFS repositories milestone
bbakernoaa
commented
Jun 9, 2025
Collaborator
Author
There was a problem hiding this comment.
we should have these all be lowercase to be inline with the other schemes
bbakernoaa
commented
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add different drydep processes for gas and zhang et al dry deposition
Note: #111 should be merged first