-
Notifications
You must be signed in to change notification settings - Fork 19
Add GOCART SUV process #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…/CATChem into feature/gocart_suv
Co-authored-by: lholland-noaa <[email protected]>
Added "assert" command
Note on data that needs to go into SUVolcanicEmissionsState
|
@lwcugb could you run Also, the assertion in the test failed with |
|
@zmoon Thanks for checking it. I made a new commit to fix the lint error as you suggested. The test works fine on my local machine with gfortran-14 too. Not sure what is special for gfortran-12. Any idea how I should fix it? |
The I would print out the array values you get with your compiler, see if they are the magnitude you expect. And I will test with Edit: in the latest run, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one might be okay to remove, but we should check with @bbakernoaa
|
@lwcugb I also merged in the update to GOCART submodule. Not sure if anything affects your work here, but here's the changelog: https://github.com/GEOS-ESM/GOCART/blob/v2.4.0/CHANGELOG.md |
Thanks for the heads up. I do have to make some minor changes and it works again. |
bbakernoaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just that scheme filename to be changed
This is an interface to GOCART Sulfur Volcanic Emissions of SO2. The PR is an update to the previous one #113