Skip to content

Conversation

@lwcugb
Copy link

@lwcugb lwcugb commented Mar 19, 2025

This is an interface to GOCART Sulfur Volcanic Emissions of SO2. The PR is an update to the previous one #113

@zmoon zmoon mentioned this pull request Mar 19, 2025
@zmoon
Copy link
Collaborator

zmoon commented Mar 19, 2025

@lwcugb could you run pre-commit run --all-files and commit the result? Then the linter should pass.

Also, the assertion in the test failed with gfortran-12 (and signaled underflow: IEEE_UNDERFLOW_FLAG IEEE_DENORMAL), but interestingly not with gfortran-10. So we should examine what's in that array.

@lwcugb
Copy link
Author

lwcugb commented Mar 19, 2025

@zmoon Thanks for checking it. I made a new commit to fix the lint error as you suggested. The test works fine on my local machine with gfortran-14 too. Not sure what is special for gfortran-12. Any idea how I should fix it?

@zmoon
Copy link
Collaborator

zmoon commented Mar 19, 2025

The test works fine on my local machine with gfortran-14 too. Not sure what is special for gfortran-12.

The IEEE_UNDERFLOW_FLAG/IEEE_DENORMAL seem to suggest that the calculations are producing numbers too small to normally represent with the selected precision (subnormal numbers), ending up in the SUVolcanicState%TotalEmission array. It seems that the gfortran-12 case is flushing those to zero, such that the sum(...) > 0 is not true.

I would print out the array values you get with your compiler, see if they are the magnitude you expect. And I will test with gfortran-12.

Edit: in the latest run, gfortran-10 and gfortran-11 failed, while gfortran-10 was working before. Perhaps hardware differences in the runners used for the different runs?

@zmoon zmoon changed the title Add updated gocart suv process Add GOCART SUV process Mar 27, 2025
@lwcugb lwcugb mentioned this pull request Mar 27, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one might be okay to remove, but we should check with @bbakernoaa

@zmoon
Copy link
Collaborator

zmoon commented Mar 27, 2025

@lwcugb I also merged in the update to GOCART submodule. Not sure if anything affects your work here, but here's the changelog: https://github.com/GEOS-ESM/GOCART/blob/v2.4.0/CHANGELOG.md

@lwcugb
Copy link
Author

lwcugb commented Mar 28, 2025

@lwcugb I also merged in the update to GOCART submodule. Not sure if anything affects your work here, but here's the changelog: https://github.com/GEOS-ESM/GOCART/blob/v2.4.0/CHANGELOG.md

Thanks for the heads up. I do have to make some minor changes and it works again.

@bbakernoaa bbakernoaa self-requested a review April 14, 2025 15:40
Copy link
Collaborator

@bbakernoaa bbakernoaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that scheme filename to be changed

@lwcugb lwcugb requested a review from bbakernoaa May 1, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request New Process Used for new processes

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants