Skip to content

Tidy up more compiler warnings #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhaesung merged 3 commits into from
Jul 11, 2025
Merged

Tidy up more compiler warnings #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b20022b
tlim_okw instead of tlim_fgf in cires_ugwpv1_triggers.F90
NickSzapiro-NOAA Jun 30, 2025
21bce1e
Initialize intent(out) zlwb in cires_ugwpv1_oro.F90
NickSzapiro-NOAA Jun 30, 2025
1694611
Set jj if dlat > 0.0, dlon <= 0.0 in sfcsub.F
NickSzapiro-NOAA Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion physics/GWD/cires_ugwpv1_oro.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ subroutine orogw_v1 (im, km, imx, me, master, dtp, kdt, do_tofd, &
dusfc(i) = 0.0
dvsfc(i) = 0.0
ipt(i) = 0
enddo
enddo
zlwb(:) = 0.0

! ---- for lm and gwd calculation points
!cires_ugwp_initialize.F90: real, parameter :: hpmax=2400.0, hpmin=25.0
Expand Down
2 changes: 1 addition & 1 deletion physics/GWD/cires_ugwpv1_triggers.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ subroutine get_spectra_tau_okw(nw, im, levs, trig_okw, xlatd, sinlat, coslat, t
if (dmax >= tlim_okw) kex = kex+1
do k=klow+1, ktop
dtot = abs(trig_okw(i,k))
if (dtot >= tlim_fgf ) kex = kex+1
if (dtot >= tlim_okw ) kex = kex+1
if ( dtot > dmax) then
klev(i) = k
dmax = dtot
Expand Down
7 changes: 5 additions & 2 deletions physics/Interstitials/UFS_SCM_NEPTUNE/sfcsub.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3093,8 +3093,11 @@ subroutine subst(data,imax,jmax,dlon,dlat,ijordr)
enddo
enddo
else
do i=1,imax
data(imax-i+1,jj) = work(i,j)
do j=1,jmax
jj = jmax - j + 1
do i=1,imax
data(imax-i+1,jj) = work(i,j)
enddo
enddo
endif
else
Expand Down