Add ECMWF non-stationary gravity wave scheme option #2714
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@BoYang-NOAA I noticed that there is no regression test log added for the tests that you've done. Could you push the tests/logs/RegressionTests_*.log from the platform where you ran the tests please? |
Collaborator
|
@BoYang-NOAA Please fill out something for the commit messages in the PR description as well. |
Author
|
I pushed the tests/logs with the commit message "add log for regression
test on Hera" a few minutes ago.
…On Wed, Apr 30, 2025 at 1:03 PM Grant Firl ***@***.***> wrote:
*grantfirl* left a comment (ufs-community/ufs-weather-model#2714)
<#2714 (comment)>
@BoYang-NOAA <https://github.com/BoYang-NOAA> Please fill out something
for the commit messages in the PR description as well.
—
Reply to this email directly, view it on GitHub
<#2714 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARTOITNSQ3QCMIYXBDDXQLT24D67FAVCNFSM6AAAAAB3T4SDGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBSGY3DCNRTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
14 tasks
Collaborator
|
@BoYang-NOAA This has been combined into #2790. Let's leave this PR open until the combined PR is merged in case it runs into problems. |
Collaborator
|
merged with #2790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
Add ECMWF Non-stationary gravity wave scheme in UGWDV1 gravity wave suite. If do_ngw_ec is set to true, use the ECMWF NGWD scheme. Conversely, if do_ngw_ec is false, use the original UGWDv1 NGWD scheme. do_ngw_ec is set to false by default.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: