bug fix to maxMF check: only access when do_mynnedmf=.true.

[SamuelTrahanNOAA]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules.
• Commit 'test_changes.list' from previous step

---

Description:

Bug fix to ufs-community/ccpp-physics#282 to guard against accessing maxMF in CCPP's cu_c3_driver.F90 when that array is not allocated.

See issue for full explanation:

• Crash in cu_c3_driver.F90 when not using mynn edmf due to access of unallocated maxMF array. ccpp-physics#282

Commit Message:

ccpp-physics - bug fix: only access maxMF when it is allocated

Priority:

• Normal

Git Tracking

UFSWM:

• None

Sub component Pull Requests:

• FV3: Bug fix to maxMF check: only access when do_mynnedmf=.true. NOAA-EMC/ufsatm#968
  • ccpp-physics: bug fix to maxMF check: only access when do_mynnedmf=.true. ccpp-physics#283

UFSWM Blocking Dependencies:

• None

Documentation:

• No documentation update is required for this PR.

No aspect of running or configuring the model changes as a result of this bug fix.

Changes

Regression Test Changes (Please commit test_changes.list):

• No Baseline Changes.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[grantfirl]

@SamuelTrahanNOAA Are you OK with combining this PR with something else in order to merge more quickly?

[SamuelTrahanNOAA]

SamuelTrahanNOAA Are you OK with combining this PR with something else in order to merge more quickly?

I don't have a tremendous amount of extra time with all the tasks I'm working on, so it would be difficult for me to manage a merge of multiple PRs. You may see some delay if we went that route. However, if someone else wants to merge mine into theirs, that's fine.

[grantfirl]

SamuelTrahanNOAA Are you OK with combining this PR with something else in order to merge more quickly?

I don't have a tremendous amount of extra time with all the tasks I'm working on, so it would be difficult for me to manage a merge of multiple PRs. You may see some delay if we went that route. However, if someone else wants to merge mine into theirs, that's fine.

Yes, I would handle it.

[SamuelTrahanNOAA]

@grantfirl - When you merge the fix, make sure you close the issue:

• Crash in cu_c3_driver.F90 when not using mynn edmf due to access of unallocated maxMF array. ccpp-physics#282

[grantfirl]

@SamuelTrahanNOAA This has been merged into #2790. We'll keep this open until the replacement is merged in case there are issues with the combined PR.

[jkbk2004]

merged with #2790