-
Notifications
You must be signed in to change notification settings - Fork 276
Bring CDEPS Inline capability to FV3 #2807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring CDEPS Inline capability to FV3 #2807
Conversation
|
Thank you @uturuncoglu! I am still catching up but I do see some reshape calls that may be important for GFS_coupling --> CCPP variables: If I understand, maybe it is worth checking what lat,lon from FV3 mesh look like if passed over to CCPP in same way |
|
@NickSzapiro-NOAA I think the issue is solved when I make change in the standard names after @DusanJovic-NOAA suggestion. At this point I am not sure what is the difference between |
|
@NickSzapiro-NOAA @junwang-noaa @DeniseWorthen It seems issue is fixed. @DusanJovic-NOAA Thanks again for your great help. Please see the latest comment in NOAA-EMC/ufsatm#988. Let me know if you want me to change those PRs ready to view. |
|
Just let me know if you also want me to include a new RT that demonstrates the capability. |
|
@junwang-noaa @DeniseWorthen @NickSzapiro-NOAA JFYI, I'll add a new RT (regional - RRFS_CONUScompact_13km, updates GL SST and ice conditions) to demonstrate the capability and this PR will be ready to review and merge. The test is created with SRW app. |
|
I think I could modify existing |
|
I am getting a persistent OOM error for |
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
|
After recloning and running the failing test on Ursa, it passed. 🎉 UPDATE: ORTs also passed on rerun. |
|
I think I typo'd my previous post, here's the hash CMEPS Hash: NOAA-EMC/CMEPS@4bb06b3 Please revert .gitmodules for CMEPS and update the CMEPS hash to the one above. |
|
UFSATM now at NOAA-EMC/ufsatm@35e9c99 please revert those .gitmodules and update UFSATM hash to that above. |
|
@uturuncoglu please make the changes mentioned previously. Thanks! |
|
@BrianCurtis-NOAA Sorry for the delay. I was in a meeting. I updated pointer for both UFSATM and CMEPS. |
|
Thanks for all your efforts to get this committed @uturuncoglu |
|
@NickSzapiro-NOAA @gspetro-NOAA @BrianCurtis-NOAA Thanks all of you for your help. It was little bit bumpy PR. Sorry about it. I also want to have a spacial thank to @grantfirl for his contribution in CCPP/physics end. |
Commit Queue Requirements:
Description:
This PR aims to bring CDEPS Inline capability to FV3 to allow updating desired fields in CCPP.
Some additional information:
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
conus13km_gl_inline_intel. It is based on conus13km grid but slightly different than the exiting configurations in terms ofinput.nml. It basically update sea surface related variables (set, sea ice variables) over the Great Lakes using FVCOM forecast output.Input data Changes:
Library Changes/Upgrades:
Testing Log: