Skip to content

Conversation

@uturuncoglu
Copy link
Collaborator

@uturuncoglu uturuncoglu commented Jul 11, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR aims to bring CDEPS Inline capability to FV3 to allow updating desired fields in CCPP.
Some additional information:

Commit Message:

* UFSWM - update for CDEPS inline capability
  * CMEPS - bring updates from CCPP GFS surface composite
  * UFSATM - update for CDEPS inline capability
    * ccpp-physics - bring CDEPS inline capability

Priority:

  • Normal

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:

  • This PR requires a documentation update, and the WM User's Guide has been updated based on the changes in this PR.
  • This PR requires a documentation update, and a WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • No documentation update is required for this PR (please explain).

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines. The new test is named as conus13km_gl_inline_intel. It is based on conus13km grid but slightly different than the exiting configurations in terms of input.nml. It basically update sea surface related variables (set, sea ice variables) over the Great Lakes using FVCOM forecast output.

Input data Changes:

  • New input data - /glade/work/turuncu/GL/RT/NEMSfv3gfs/input-data-20250507/FV3_input_data_cdeps_inline

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@NickSzapiro-NOAA
Copy link
Collaborator

Thank you @uturuncoglu!

I am still catching up but I do see some reshape calls that may be important for GFS_coupling --> CCPP variables:
https://github.com/search?q=repo%3ANOAA-EMC%2Ffv3atm%20reshape&type=code

If I understand, maybe it is worth checking what lat,lon from FV3 mesh look like if passed over to CCPP in same way

@uturuncoglu
Copy link
Collaborator Author

@NickSzapiro-NOAA I think the issue is solved when I make change in the standard names after @DusanJovic-NOAA suggestion. At this point I am not sure what is the difference between horizontal_dimension vs. horizontal_loop_extent in the definition and how was it working in the first place before CCPP RP in the past but it looks it fixed the issue. See following commit - NOAA-EMC/ufsatm#988 (comment). I am running model with/without inline at this point to be sure it is working. The fields are in CCPP side looks good at this point. I'll add couple of plots to the PR.

@uturuncoglu
Copy link
Collaborator Author

@NickSzapiro-NOAA @junwang-noaa @DeniseWorthen It seems issue is fixed. @DusanJovic-NOAA Thanks again for your great help. Please see the latest comment in NOAA-EMC/ufsatm#988. Let me know if you want me to change those PRs ready to view.

@uturuncoglu
Copy link
Collaborator Author

Just let me know if you also want me to include a new RT that demonstrates the capability.

@uturuncoglu
Copy link
Collaborator Author

@junwang-noaa @DeniseWorthen @NickSzapiro-NOAA JFYI, I'll add a new RT (regional - RRFS_CONUScompact_13km, updates GL SST and ice conditions) to demonstrate the capability and this PR will be ready to review and merge. The test is created with SRW app.

@uturuncoglu
Copy link
Collaborator Author

uturuncoglu commented Jul 23, 2025

I think I could modify existing conus13km_control and enable inline capability in it. So, new test would be conus13km_control_inline.

@gspetro-NOAA gspetro-NOAA added the jenkins-ort run ORT testing label Jan 16, 2026
@gspetro-NOAA
Copy link
Collaborator

I am getting a persistent OOM error for control_p8_ugwpv1_tempo_aerosol_hail_intel on Ursa only. Here is my latest run_dir: /scratch4/NAGAPE/epic/Gillian.Petro/stmp/RT_RUNDIRS/Gillian.Petro/FV3_RT/rt_115204.
Some of the ORTs also failed. Rerunning and will check in the morning.

 on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@epic-cicd-jenkins epic-cicd-jenkins removed the jenkins-ort run ORT testing label Jan 16, 2026
@gspetro-NOAA
Copy link
Collaborator

gspetro-NOAA commented Jan 16, 2026

After recloning and running the failing test on Ursa, it passed. 🎉

UPDATE: ORTs also passed on rerun.

@BrianCurtis-NOAA
Copy link
Collaborator

I think I typo'd my previous post, here's the hash

CMEPS Hash: NOAA-EMC/CMEPS@4bb06b3

Please revert .gitmodules for CMEPS and update the CMEPS hash to the one above.

@gspetro-NOAA gspetro-NOAA removed the In Testing The PR that is currently in testing stages label Jan 16, 2026
@BrianCurtis-NOAA
Copy link
Collaborator

BrianCurtis-NOAA commented Jan 16, 2026

UFSATM now at NOAA-EMC/ufsatm@35e9c99

please revert those .gitmodules and update UFSATM hash to that above.

@BrianCurtis-NOAA
Copy link
Collaborator

@uturuncoglu please make the changes mentioned previously. Thanks!

@uturuncoglu
Copy link
Collaborator Author

@BrianCurtis-NOAA Sorry for the delay. I was in a meeting. I updated pointer for both UFSATM and CMEPS.

@gspetro-NOAA gspetro-NOAA merged commit 8cb3a82 into ufs-community:develop Jan 16, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from Schedule to Done in PRs to Process Jan 16, 2026
@NickSzapiro-NOAA
Copy link
Collaborator

Thanks for all your efforts to get this committed @uturuncoglu

@uturuncoglu
Copy link
Collaborator Author

@NickSzapiro-NOAA @gspetro-NOAA @BrianCurtis-NOAA Thanks all of you for your help. It was little bit bumpy PR. Sorry about it. I also want to have a spacial thank to @grantfirl for his contribution in CCPP/physics end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Adds Input Data New input data needs to be added (e.g., for new test). No existing input data is changed. CCPP There are changes to a CCPP repository. CMEPS There are changes to the CMEPS component repository. New Baselines New baselines will be added to project. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. UFSATM There are changes to the UFSATM repository.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants