Update SFS test to C192mx025; add debug and restart tests; update ultralow warmstart input to specify V2 file type // Address some compiler warnings in UFSATM and UPP: round 2 (#2958)

[DeniseWorthen]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
• Commit 'test_changes.list' from previous step

---

Description:

#2835

1. Replaces current C96mx100 SFS test with a configuration matching the current SFS C192mx025 prototype configuration. Adds a restart and debug test for SFS. The SFS input data is from CORe.

Warmstarts for ICE and OCN are from

/gpfs/f6/sfs-emc/scratch/Neil.Barton/ICs/CPC/C192mx025/sfs.19940430/18/mem000/model

The ATM ICs are from

/gpfs/f6/sfs-emc/scratch/Neil.Barton/ICs/CPC/C192mx025/sfs.19940501/00/mem000/model/atmos/input

The ATM and OCN increment files are from

/gpfs/f6/sfs-emc/scratch/Neil.Barton/ICs/CPC/C192mx025/sfs.19940501/00/mem001/analysis

The fix files are identical to those in

/gpfs/f6/drsa-precip3/world-shared/role.glopara/fix/orog/20240917/C192
/gpfs/f6/drsa-precip3/world-shared/role.glopara/fix/ugwd/20240624/C192

For example, the oro files (e.g. oro_data.tile1.nc) used by the RT are source from

FV3_fix_tiled/C192mx025/oro_C192.mx025.tile1.nc

and these are identical to those in role.glopara/fix/orog/20240917/C192/C192.mx025_oro_data.tile2.nc

However, the C192 grid files (eg C192_grid.tile4.nc) are not identical . In the RTs, these are source from

FV3_input_data192/INPUT/C192_grid.tile1.nc

and these files have small round-off level differences w/ the grid files in role.glopara/fix/orog/20240917/C192/. I don't believe this is an issue unless an attempt is made to repro a G-W run and an RT run.

Note that because the ATM is writing history files every 24 hours for the control test, the restart and debug tests compare only restart files from all components; the surface history files will not be B4B because the accumulated fields in the surface files will not be B4B.

At commit 3acafc1, this is the input.nml difference between the new cpld_control_sfs and the initial SFS sandbox provided. I've removed the differences in the fix files, which differ only the path-to-file.

diff -yw --suppress-common-lines /gpfs/f6/infra-cpu/world-shared/Denise.Worthen/sfs192mx025.rundir/input.nml cpld_control_sfs_intel/input.nml | grep -v FN

sandbox	rt test
res_latlon_dynamics = atminc.nc	res_latlon_dynamics = 'atminc.nc'
	mraerosol = .false.
	lthailaware = .false.
	do_ngw_ec = .true.
	use_oceanuv = .false.
STOCHINI=.false.,	STOCHINI=.false.
	new_lscale=.true.
skebint = 1800	skebint = 0
shumint = 3600	shumint = 0
spptint = 1800	spptint = 0
LNDP_TAU=21600	LNDP_TAU=21600,
LNDP_LSCALE=500000	LNDP_LSCALE=500000,
output_directory = 'MOM6_OUTPUT/',	output_directory = './MOM6_OUTPUT',
restart_output_dir = 'MOM6_RESTART/'	restart_output_dir = './RESTART/'

2. Replaces the current ultra-low warmstart staged inputs with files properly containing the V2 global attribute. The warmstart files were created using this branch at 569d4ac

#2958

Compiling ufs-weather-model RT cpld_debug_gfsv17 (in intel debug mode) gives a number of compiler
warning #8889: Explicit interface or EXTERNAL declaration is required
from UPP subroutines. To fix with minimal code changes, the UPP subroutines are added to modules on UPP side and UFSATM uses those modules to provide an explicit interface.

Commit Message:

* UFSWM - Point RTs to new input-data directory with fixes for ultralow warmstart files and new SFS configuration
* UFSWM - Update configuration of SFS test to C192mx025 and add a restart and debug test
* UFSWM - Rename diag table template for SFS to diag_table_sfs.IN
* UFSWM - Add namelist parameters to control use of ECMWF non-stationary gravity wave scheme, tte_edmf and cscale
* UFSWM - Add namelist parameter to set new_lscale for stochastic physics
* UFSWM - Use UPP modules in UFSATM for explicit interfaces in post
  * UFSATM - Add 'file_version' global attribute to sfc_data restart files, as defined in input sfc_data files
  * UFSATM - Use UPP modules in UFSATM for explicit interfaces in post; update UPP hash
  * stochastic_physics - Restrict print messages to be on root PE only

Priority:

• Normal

Git Tracking

UFSWM:

• Fixes Create C192mx025 regression test configuration #2764
• Fixes diagnostic messages are written on all PEs and not controlled by flag to turn off NOAA-PSL/stochastic_physics#87
• Fixes Restart outputs are not b4b identical to cold-start run when sfc v2 files are used #2827
• Fixes Add namelist parameters which need to be non-default values for the SFS RT  #2840
• Fixes Ultralow warmstart/restart tests do not properly test V2 file type #2917
• Fixes Add new_lscale as a configurable parameter #2923
• Part of Compile warnings in UFS and subcomponents #2703

Sub component Pull Requests:

• FV3: Add 'file_version' global attribute to sfc_data restart files NOAA-EMC/ufsatm#997 (pulls in changes from Modules fix explicit interface compiler warnings for post to call UPP NOAA-EMC/ufsatm#1030)
• stochastic_physics: print messages on rootpe only NOAA-PSL/stochastic_physics#88

UFSWM Blocking Dependencies:

• None

Documentation:

• No documentation update is required for this PR (please explain). No non-documented features are added.

---

Changes

Regression Test Changes (Please commit test_changes.list):

Baseline changes are due to

1. Changes for tests relying on V2 global attribute in the ATM restart files
2. Changes for test configuration from c96mx100->c192mx025 for SFS

Pre-testing on C6 using a staged baseline for the ultralow and SFS test shows that:

1. Warmstart and restart tests for ultralow and new SFS tests reproduce
2. SFS runs and reproduces in debug mode

Input data Changes:

• New input data.

This PR requires a NEW input-data directory to both add the files required for the new SFS test as well as fixing the ultralow staged input.

The NEW input-data directory is located on Ursa at

/scratch4/NCEPDEV/nems/Denise.Worthen/input-data-2025XXXX

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
  • Ursa
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[DeniseWorthen]

@gspetro-NOAA None of my testing was on either Hera or Hercules, so I would not have caught the missing MPAS. Argh!

You will need to add the MPAS/INPUT/120km/Global directory to the new input-data-20251015 everywhere, even if we only run now on Hera and Hercules. FYI @BrianCurtis-NOAA for WCOSS/Acorn.

EDIT: Ursa is supposed to be our "base" platform, but MPAS isn't run there?

[gspetro-NOAA]

@gspetro-NOAA None of my testing was on either Hera or Hercules, so I would not have caught the missing MPAS. Argh!

You will need to add the MPAS/INPUT/120km/Global directory to the new input-data-20251015 everywhere, even if we only run now on Hera and Hercules. FYI @BrianCurtis-NOAA for WCOSS/Acorn.

EDIT: Ursa is supposed to be our "base" platform, but MPAS isn't run there?

No worries--it's an easy enough fix! And yes, when that test was put in (in PR #2780), it was supposed to also run on Ursa, but the test kept failing there. The only way to move forward with the PR was to take Ursa off that test. Since there are plans for a series of MPAS-related PRs, the understanding was that @dustinswales and his team would continue working on it. Unfortunately, I think the shutdown has probably slowed that work considerably... :-/

[gspetro-NOAA]

Ok, MPAS data is in place on RDHPCS!

[FernandoAndrade-NOAA]

We should be all set with RT logs, leaving a note in sub PRs.

[jkbk2004]

NOAA-PSL/stochastic_physics@aea3150 new hash for stochastic physics

[jkbk2004]

NOAA-EMC/ufsatm@b667c11 new hash for ufsatm