-
Notifications
You must be signed in to change notification settings - Fork 276
Add tracing instrumentation #2884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing instrumentation #2884
Conversation
|
@DusanJovic-NOAA This tracing will always be "on"; did you think about making it optional? I think each component would then need to retrieve an attribute (? EDIT: I see now that the PR includes the information that you need to compile w/ UFS_TRACING=ON. |
Yes. Tracing will not be always "on". By default, it's "off". You turn it on by setting -DUFS_TRACING=ON. It's a build time option, not a run time. It must be a built time, because when components are used outside the UFS, the tracing subroutine is not going to be available, all tracing calls must be ifdef-ed out. |
|
@DusanJovic-NOAA I see this PR is open, but the PR template is not fully filled out. Do you have an estimate of when it will be ready/what remains to be done before we schedule it? |
Done. |
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
|
Heads up that there's a delay for the Hercules tests. RTs seemed to be hanging with a "launch failed requeued held" reason listed. I recloned and reran tests last night, and they hung around the same point (~250/320 remaining). This morning, while I was looking into reasons that might be, they restarted again and seem to be running fine, so now I'm just waiting for jobs to complete. |
|
WW3 hash: NOAA-EMC/WW3@ae7faa5 |
Commit Queue Requirements:
Description:
This PR adds a simple tracing module and updates some sub components' nuopc drivers to produce a trace file which can be used to identify performance issues.
The tracing module is not built and used by default. It can be enabled by setting a build option `-DUFS_TRACING=ON'
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: