-
Notifications
You must be signed in to change notification settings - Fork 276
Update submodule pointer for UFSATM (CCPP metadata updates) // Remove faster tests (#3003) #2983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submodule pointer for UFSATM (CCPP metadata updates) // Remove faster tests (#3003) #2983
Conversation
…r-model into feature/ccpp_rel_path_dep_path
…r-model into feature/ccpp_rel_path_dep_path
…limbfuji/ufs-weather-model into feature/ccpp_rel_path_dep_path
|
@BrianCurtis-NOAA @DeniseWorthen Something is off with the repo check script. It complains that my code isn't up to date, but I pulled in develop just before I pushed the code, and I just tried again https://github.com/ufs-community/ufs-weather-model/actions/runs/19576413857/job/56062859932 |
|
@climbfuji Agreed. I've been getting constant failures. |
|
@DeniseWorthen I reran rt on Ursa. This time, one test failed, and there were no compilation errors I think: |
* faster is now default
…r-model into feature/ccpp_rel_path_dep_path
…limbfuji/ufs-weather-model into feature/ccpp_rel_path_dep_path
|
@DeniseWorthen I've pulled in your changes--please confirm that everything looks right. :) |
|
@gspetro-NOAA Looks good. |
climbfuji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my end
on-behalf-of @ufs-community <[email protected]>
|
@BrianCurtis-NOAA Just checking in to see how the RTs are doing on WCOSS2/Acorn. |
Both are in maintenance. 🫣 returning hopefully by 2. 🫠🫥 |
|
All set! |
Great! Left a note in the sub-PRs. |
|
@climbfuji You can revert .gitmodules and update hashes: |
Thanks, done! |
Commit Queue Requirements:
test_changes.listindicates which tests, if any, are changed by this PR. Committest_changes.list, even if it is empty.Description:
#2983
Update submodule pointer for UFSATM (CCPP metadata updates, point to head of ccpp-framework develop)
#3003
Removes compile jobs and tests which were previously "faster", since faster is now the default.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Note
When I ran the verification against the baseline on ursa, one test timed out. I am very certain this has nothing to do with my changes, therefore didn't spend the extra effort rerunning the test - I committed the logs as they were.
These two tests timed out:
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: