Skip to content

Conversation

@climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Nov 16, 2025

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

#2983

Update submodule pointer for UFSATM (CCPP metadata updates, point to head of ccpp-framework develop)

#3003

Removes compile jobs and tests which were previously "faster", since faster is now the default.

Commit Message:

* UFSWM - remove compile jobs and tests associated w/ "faster"
* UFSWM - Update submodule pointer for UFSATM (CCPP metadata updates, point to head of ccpp-framework develop)
  * UFSATM - CCPP metadata-only changes; ccpp-framework update to head of "develop" branch 
    * ccpp-physics - CCPP metadata: relative_path --> dependencies_path
    * ccpp-framework - CCPP metadata: relative_path --> dependencies_path & point to head of develop
  * CMEPS: CCPP metadata: relative_path --> dependencies_path

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation: doc updates are made in the separate ccpp-doc repository

Changes

Note

When I ran the verification against the baseline on ursa, one test timed out. I am very certain this has nothing to do with my changes, therefore didn't spend the extra effort rerunning the test - I committed the logs as they were.

These two tests timed out:

[Dom.Heinzeller@uecflow01 tests]$ pwd
/scratch3/BMC/gmtb/Dom.Heinzeller/ufs-ccpp-dep-path/tests
[Dom.Heinzeller@uecflow01 tests]$ ls -1 | grep fail
fail_test_regional_control_faster_intel

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@climbfuji climbfuji changed the title Update submodule pointer for UFSATM (ccpp-framework and ccpp-physics updates) Update submodule pointer for UFSATM (CCPP metadata updates) Nov 20, 2025
@climbfuji climbfuji marked this pull request as ready for review November 20, 2025 23:02
@climbfuji
Copy link
Collaborator Author

@BrianCurtis-NOAA @DeniseWorthen Something is off with the repo check script. It complains that my code isn't up to date, but I pulled in develop just before I pushed the code, and I just tried again

https://github.com/ufs-community/ufs-weather-model/actions/runs/19576413857/job/56062859932

@DeniseWorthen
Copy link
Collaborator

@climbfuji Agreed. I've been getting constant failures.

@climbfuji
Copy link
Collaborator Author

@DeniseWorthen I reran rt on Ursa. This time, one test failed, and there were no compilation errors I think:

[Dom.Heinzeller@uecflow01 tests]$ pwd
/scratch3/BMC/gmtb/Dom.Heinzeller/ufs-ccpp-dep-path/tests
[Dom.Heinzeller@uecflow01 tests]$ ls -1 | grep fail
fail_test_regional_control_faster_intel

@gspetro-NOAA gspetro-NOAA added No Baseline Change No Baseline Change UFSATM There are changes to the UFSATM repository. CCPP There are changes to a CCPP repository. CMEPS There are changes to the CMEPS component repository. labels Nov 21, 2025
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Waiting for Reviews (subcomponent) in PRs to Process Nov 21, 2025
@gspetro-NOAA gspetro-NOAA moved this from Waiting for Reviews (subcomponent) to Review in PRs to Process Dec 2, 2025
@gspetro-NOAA
Copy link
Collaborator

@DeniseWorthen I've pulled in your changes--please confirm that everything looks right. :)

@DeniseWorthen
Copy link
Collaborator

@gspetro-NOAA Looks good.

@gspetro-NOAA gspetro-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. In Testing The PR that is currently in testing stages labels Dec 15, 2025
Copy link
Collaborator Author

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end

@jkbk2004 jkbk2004 added the jenkins-ort run ORT testing label Dec 15, 2025
@epic-cicd-jenkins epic-cicd-jenkins removed the jenkins-ort run ORT testing label Dec 16, 2025
@gspetro-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA Just checking in to see how the RTs are doing on WCOSS2/Acorn.

@BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA Just checking in to see how the RTs are doing on WCOSS2/Acorn.

Both are in maintenance. 🫣 returning hopefully by 2. 🫠🫥

@BrianCurtis-NOAA
Copy link
Collaborator

All set!

@gspetro-NOAA
Copy link
Collaborator

All set!

Great! Left a note in the sub-PRs.

@gspetro-NOAA
Copy link
Collaborator

@climbfuji You can revert .gitmodules and update hashes:

@climbfuji
Copy link
Collaborator Author

@climbfuji You can revert .gitmodules and update hashes:

Thanks, done!

@gspetro-NOAA gspetro-NOAA removed the In Testing The PR that is currently in testing stages label Dec 17, 2025
@gspetro-NOAA gspetro-NOAA merged commit 43af37a into ufs-community:develop Dec 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCPP There are changes to a CCPP repository. CMEPS There are changes to the CMEPS component repository. No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. UFSATM There are changes to the UFSATM repository.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove "faster" tests CCPP metadata update: relative_path --> dependencies_path

7 participants