shakedown: wave 14: guided picker for ./run (interactive, builds the run from answers)#11
Merged
Conversation
…run from answers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asked for by the user: with no flags on a terminal,
./runnow guides you instead of making you remember flags.What it does
interactive_picker(): bare./runon a TTY detects the SKU for a header, then asks "verify a new Mac (thorough) vs quick check", and for the thorough path two follow-ups (strict gating, and the opt-in AI/LLM load). It echoes the command it built (-> ./run --store --strict), prints a one-line heads-up, and flows straight into the run.--storeexpansion andexport STRICTpick them up (no reordering).SHAKEDOWN_YES=1to skip the second "Proceed?" prompt.Skipped cleanly (unchanged behavior)
Any explicit flag (
ARGC > 0), a non-interactive stdin (-t 0false: pipe /< /dev/null/ CI), orSHAKEDOWN_YES=1bypasses the picker entirely. Scripted and flag-driven use is identical to before.Verification
--store --strict; 1+n+y ->--store --llama; 2 -> default; 3 -> prints--helppointer and exits 0; all of 1/2 setSHAKEDOWN_YES=1so the second prompt is skipped.set -uerror (the trap is installed ~300 lines later, after the picker)../run --no-sudo < /dev/nullskips the picker (0 menu lines) and completes normally../run+ "pick option 1", CHANGELOG).Passed dad review: correctness clean (a flagged "will-break" trap-vs-set-u issue was a false positive, verified by ordering + the live PTY run); applied the consistency fixes (
read -r -p, lowercaseshakedown:header) and the simplicity fix (flow into the run instead of double-prompting).