fix: tighten up Object.values and Object.entries types #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #40
This fix tightens up
Object.values
andObject.entries
types so that:Object.values({})
returnsunknown[]
(previouslynever[]
)Object.values({ foo: 123 })
returnsunknown[]
(previouslynumber[]
)To get non-
unknown[]
results you need to pass a value of typeRecord<string, T>
.This isn't still perfect but less unsafe than before.