-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/2.8.1 #54
Release/2.8.1 #54
Conversation
stephen-dixon
commented
Dec 17, 2024
•
edited
Loading
edited
- Improving performance of bytes plugin
- Adding fixes for fatclient pyuda build
- adding support for python3.13 wheels in linux and macos (not windows)
- fixing timestamp microseconds error in uda logging
- updates to documentation and adding a contributing.md
- fixing some UKAEA issues with the IDL wrapper
… bytes, and UDA_TYPE_OPAQUE is handled as raw bytes.
…#53) `libtirpc-dev` is required for building UDA on Ubuntu, however it isn't installed by default in all Ubuntu images (for instance in the WSL2 distribution for Ubuntu 24.04).
…ks with old client.
…load in multiple chunks with a progress bar.
@@ -149,7 +149,7 @@ int TemplatePlugin::help(IDAM_PLUGIN_INTERFACE* idam_plugin_interface) | |||
*/ | |||
int TemplatePlugin::version(IDAM_PLUGIN_INTERFACE* idam_plugin_interface) | |||
{ | |||
return setReturnDataIntScalar(idam_plugin_interface->data_block, THISPLUGIN_VERSION, "Plugin version number"); | |||
return setReturnDatastring(idam_plugin_interface->data_block, UDA_BUILD_VERSION, "Plugin version number"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing #include <version.h>
source/plugins/bytes/bytesPlugin.cpp
Outdated
{ | ||
return setReturnDataIntScalar(plugin_interface->data_block, THISPLUGIN_VERSION, "Plugin version number"); | ||
setReturnDataString(plugin_interface->data_block, UDA_BUILD_VERSION, "Plugin version number"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setReturnDataString(plugin_interface->data_block, UDA_BUILD_VERSION, "Plugin version number"); | |
return setReturnDataString(plugin_interface->data_block, UDA_BUILD_VERSION, "Plugin version number"); |
source/plugins/udaPlugin.cpp
Outdated
|
||
return 0; | ||
setReturnDataUnsignedIntScalar(DATA_BLOCK* data_block, unsigned int value, const char* description) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setReturnDataUnsignedIntScalar(DATA_BLOCK* data_block, unsigned int value, const char* description) | |
int setReturnDataUnsignedIntScalar(DATA_BLOCK* data_block, unsigned int value, const char* description) |
cmake --build build --config Debug --target intall | ||
``` | ||
|
||
### Running a development server under xinetd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this section better be simply a reference to /UDA/server_installation#xinetd and also mention systemd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I can clarify the text. The method here isn't appropriate for a production server but is an easy way to run just for testing and development - this is why I thought it could have a separate section here. It also doesn't require sudo rights or cause any interruption to other servers on the host (compared to moving files to /etc
and restarting system services using systemctl restart xinetd
or similar).
We currently only have the one script to do this for xinetd, but it's worth clarifying that for those who have to use launchd or systemd they will have to follow the full instructions in the server_installation section.
What do you think?
…function instead of checknamesarelegal
Tests passing at ukaea (server deplyoment on rocky8, testplugin tests, client deployment on centos7 and mast data regression tests) |
* Remove numpy2.0 limit and add 3.13 to wheel support for macos * Bump github action checkout version of cmake.yml * Limit the numpy v2.0 build for python3.9 and above --------- Co-authored-by: stephen-dixon <[email protected]>