Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.8.1 #54

Merged
merged 58 commits into from
Jan 23, 2025
Merged

Release/2.8.1 #54

merged 58 commits into from
Jan 23, 2025

Conversation

stephen-dixon
Copy link
Contributor

@stephen-dixon stephen-dixon commented Dec 17, 2024

  • Improving performance of bytes plugin
  • Adding fixes for fatclient pyuda build
  • adding support for python3.13 wheels in linux and macos (not windows)
  • fixing timestamp microseconds error in uda logging
  • updates to documentation and adding a contributing.md
  • fixing some UKAEA issues with the IDL wrapper

stephen-dixon and others added 28 commits September 11, 2024 17:39
… bytes, and UDA_TYPE_OPAQUE is handled as raw bytes.
…#53)

`libtirpc-dev` is required for building UDA on Ubuntu, however it isn't installed by default in all Ubuntu images (for instance in the WSL2 distribution for Ubuntu 24.04).
…load in multiple chunks with a progress bar.
@olivhoenen olivhoenen requested a review from deepakmaroo January 8, 2025 10:47
@@ -149,7 +149,7 @@ int TemplatePlugin::help(IDAM_PLUGIN_INTERFACE* idam_plugin_interface)
*/
int TemplatePlugin::version(IDAM_PLUGIN_INTERFACE* idam_plugin_interface)
{
return setReturnDataIntScalar(idam_plugin_interface->data_block, THISPLUGIN_VERSION, "Plugin version number");
return setReturnDatastring(idam_plugin_interface->data_block, UDA_BUILD_VERSION, "Plugin version number");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing #include <version.h>

source/plugins/help/help_plugin.cpp Outdated Show resolved Hide resolved
{
return setReturnDataIntScalar(plugin_interface->data_block, THISPLUGIN_VERSION, "Plugin version number");
setReturnDataString(plugin_interface->data_block, UDA_BUILD_VERSION, "Plugin version number");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setReturnDataString(plugin_interface->data_block, UDA_BUILD_VERSION, "Plugin version number");
return setReturnDataString(plugin_interface->data_block, UDA_BUILD_VERSION, "Plugin version number");

source/plugins/template/templatePlugin.cpp Outdated Show resolved Hide resolved

return 0;
setReturnDataUnsignedIntScalar(DATA_BLOCK* data_block, unsigned int value, const char* description)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setReturnDataUnsignedIntScalar(DATA_BLOCK* data_block, unsigned int value, const char* description)
int setReturnDataUnsignedIntScalar(DATA_BLOCK* data_block, unsigned int value, const char* description)

source/plugins/udaPlugin.cpp Outdated Show resolved Hide resolved
cmake --build build --config Debug --target intall
```

### Running a development server under xinetd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this section better be simply a reference to /UDA/server_installation#xinetd and also mention systemd?

Copy link
Contributor Author

@stephen-dixon stephen-dixon Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I can clarify the text. The method here isn't appropriate for a production server but is an easy way to run just for testing and development - this is why I thought it could have a separate section here. It also doesn't require sudo rights or cause any interruption to other servers on the host (compared to moving files to /etc and restarting system services using systemctl restart xinetd or similar).

We currently only have the one script to do this for xinetd, but it's worth clarifying that for those who have to use launchd or systemd they will have to follow the full instructions in the server_installation section.

What do you think?

@stephen-dixon
Copy link
Contributor Author

Tests passing at ukaea (server deplyoment on rocky8, testplugin tests, client deployment on centos7 and mast data regression tests)

* Remove numpy2.0 limit and add 3.13 to wheel support for macos

* Bump github action checkout version of cmake.yml

* Limit the numpy v2.0 build for python3.9 and above
---------

Co-authored-by: stephen-dixon <[email protected]>
@stephen-dixon stephen-dixon merged commit 8515a1a into main Jan 23, 2025
33 checks passed
@stephen-dixon stephen-dixon deleted the release/2.8.1 branch January 23, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants