Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store the last game state for end_of_round #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andquintero
Copy link

When running the end_of_round function, the last_game_state was actually the previous game state, this stores the real final game state

@fdraxler
Copy link
Collaborator

Thanks for the PR. To avoid off-by-one confusion, can you specify which state you expected? My idea was that the last game state is None (i.e. the state after the game ended), so I tried to pass the state the agent last took an action as last_game_state to end_of_round.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants