TP2000-1444 Require a current workbasket on workbasket checks and violations views #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 620 620
Lines 47329 47352 +23
Branches 3343 3349 +6
=======================================
+ Hits 44070 44093 +23
Misses 2619 2619
Partials 640 640 ☔ View full report in Codecov by Sentry. |
paulpepper-trade
approved these changes
Jul 11, 2024
dalecannon
changed the title
dalecannon
deleted the
TP2000-1444--workbasket-checks-view-require-current-workbasket
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1444 Require a current workbasket on workbasket checks and violations views
Why
Uncaught exceptions are raised and a generic server error page is displayed when attempting to access the workbasket checks view (
/workbaskets/current/checks/) or workbasket violations view (/workbaskets/current/violations/) without a current workbasket.What
require_current_workbasketdecorator on bothWorkBasketsChecksViewandWorkBasketsViolations, redirecting users without a current workbasket to theNoActiveWorkbasketview, where users are invited to create or select a new workbasket (like other views that require a current workbasket do)