Fix measure bulk create error #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalecannon
reviewed
Jul 12, 2024
measures/forms.py
Outdated
| # Perculiarly, this Form requires a prefix of "geographical_area". | ||
| return { | ||
| "prefix": self.prefix, | ||
| "prefix": cls.prefix, |
There was a problem hiding this comment.
Does the prefix need to be specified as "geographical_area" like before or added as new class attribute on the form before it can be used?
There was a problem hiding this comment.
Since I (clearly wrongly!!) assumed that tests would fail if it WAS empty I just assumed it was fine. It's actually empty! I have another regression test to write! 🤦♀️
There was a problem hiding this comment.
Discussed with Steve. Writing tests for this code is going to take a bit longer (currently working on it) so he's given the go-ahead to deploy this fix without tests for now
dalecannon
approved these changes
Jul 16, 2024
CPrich905
approved these changes
Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix measure bulk create error
Why
What