TP2000-1404: Reorganise measures and common code #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eadpearce
commented
Jul 17, 2024
| @@ -0,0 +1,3 @@ | |||
| from .base import * | |||
There was a problem hiding this comment.
I considered importing every function explicitly but decided against it since it would just be a burden on devs making changes to those files in future having to remember to explicitly import new functions in here (I know I would definitely forget and then wonder why I'm getting an error)
eadpearce
commented
Jul 17, 2024
| @@ -0,0 +1,6 @@ | |||
| from .base import * | |||
There was a problem hiding this comment.
Same again here. import * in this particular context is more future-proof than importing everything explicitly
|
@paulpepper-trade Nope. No code changes. Just moving things around and adding the init imports |
paulpepper-trade
approved these changes
Jul 26, 2024
emileswarts
pushed a commit
that referenced
this pull request
Jul 29, 2024
* Split up common views * Split up measures views and forms code * Add imports to module __init__ files * Fix test * Remove empty files * Tidy up common views imports * Revert imports * Revert import * Revert comment * Fix import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1404: Reorganise measures and common code
Why
What
__init__files so we can still use the same import paths - measures.forms, measures.views, common.views