Add new IcfgBuilder #690
Open
Add new IcfgBuilder #690
+12,868
−8,777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heizmann
requested review from
maul-esel,
bahnwaerter,
danieldietsch and
schuessf
schuessf
reviewed
Oct 23, 2024
trunk/examples/settings/automizer/ForwardPredicates_IcfgBuilder.epf
Outdated
Show resolved
Hide resolved
| VAL [#NULL!base=0, #NULL!offset=0] | ||
| [L31] assert false; | ||
| VAL [#NULL!base=0, #NULL!offset=0] | ||
| [L49] CALL call ULTIMATE.init(); |
There was a problem hiding this comment.
What has changed in the backtranslation that is relevant for this test?
There was a problem hiding this comment.
I was just wondering why you changed already this path and not the others.
...informatik/ultimate/plugins/generator/icfgbuilder/preferences/IcfgPreferenceInitializer.java
Show resolved
Hide resolved
...c/de/uni_freiburg/informatik/ultimate/plugins/generator/icfgbuilder/WeakestPrecondition.java
Show resolved
Hide resolved
trunk/examples/settings/automizer/ForwardPredicates_IcfgBuilder.epf
Outdated
Show resolved
Hide resolved
...e/uni_freiburg/informatik/ultimate/plugins/generator/rcfgbuilder/cfg/LargeBlockEncoding.java
Outdated
Show resolved
Hide resolved
Otherwise the StepInfo is reset, since mutable sets are used.
… when we build the new block
… startet when we build the new block" This reverts commit ba104cf.
Bugfix for cases where atomic blocks end with an IfStatement.
* Rename identifiers * Add documentation * Make method void (returned object is an argument of method)
* Rename identifiers * Add documentation * Make method void (returned object is an argument of method)
* extract method for building IcfgLocations * remove method that became obsolete
* Bugfix: Do not merge loop entry and location after invariant. * Rename identifiers
Do not copy annotations directly from original statements to edges but only to auxiliary statements. (Because annotations are copied from all statements to edges anyway.)
Unify code for prepending statements
Use assumption that mapping returns singleton except for calls.
The setting "Only consider context switches at boundaries of atomic blocks" (aka the nodatarace-LBE) is only meant to affect concurrent programs. It performs a kind of large-block encoding (LBE) that is usually not desirable for sequential programs.
schuessf
force-pushed
the
wip/nk/icfgbuilder
branch
from
105740d
to
d00bf86
Compare
IcfgBuilder is already the default anyway.
|
I just synced the |
|
@Heizmann I just noted that the old // Rationale: <code>assume true</ code> statements can be omitted, unless they
// carry attributes or indicate an overapproximation.
if (mRemoveAssumeTrueStmt && isPlainAssumeTrueStatement(st) && !isOverapproximation(st)) {
mRemovedAssumeTrueStatements++;
continue;
}This is currently not present in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits for switching from RCFGBuilder to IcfgBuilder are missing in this branch. But Frank convinced me to already start a pull request.