Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyPI deploy action #17

Merged
merged 1 commit into from
May 31, 2024
Merged

Update PyPI deploy action #17

merged 1 commit into from
May 31, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 31, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Streamlined Python package publishing process for improved compatibility and efficiency.

πŸ“Š Key Changes

  • Updated GitHub Actions workflow for package publishing.
  • Removed in-place editable install (-e .) combined with Ultralytics package, ensuring a more standard installation process.
  • Added explicit uninstallation of older thop versions to prevent conflicts.
  • Reordered installation commands for clarity and efficiency.

🎯 Purpose & Impact

  • Enhanced Compatibility: By uninstalling conflicting older thop versions before installation, this change ensures that the latest version of thop from this repository doesn't face installation issues. This is particularly useful for users who need the latest features and fixes.
  • Streamlined Installation Process: Splitting the installation process (removing the combination of editable install with the Ultralytics package) makes the GitHub Action more readable and easier to maintain, potentially speeding up the publishing process and reducing errors.
  • Efficiency and Reliability: These changes aim to make the package release process more efficient and reliable, ultimately providing users with quicker access to stable releases.

πŸ”„ Overall, these adjustments make the package more user-friendly and the development process smoother, benefiting both the maintainers and end-users of the thop package.

@glenn-jocher glenn-jocher changed the title Replace distutils with packaging Update PyPI deploy action May 31, 2024
@glenn-jocher glenn-jocher merged commit f194f5f into main May 31, 2024
1 check passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch May 31, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant