chore: revamp community site snippets #208
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a new Umami user, I've been going through the Umami docs and website a lot and I've noticed that community sites snippets are visually quite dimmed down and hard to read, almost as turned off, with color contrast of
1.53
(on contrast scale1-21
,1
is invisible eg white-on-white,21
being default/max contrast, black-on-white; according to accessibility standards,4
is required minimum and7+
recommended minimum). Additionally, there happened to be some invalid HTML.I made some example changes in PR, if something should be useful from it:
@umami/react-zen
similar to the shiso blog implementation; also style-wise.15
by removing the former light gray styling.target="_blank"
link setup as it is used sitewide on similar link types, otherwise I'd remove it as it is not recommended practice nowadays in terms of best practices (ie only for certain cases; also, links that open a new window/tab should be denoted as such in terms of a11y). I haven't found aLink
react-zen component, so I've leaved the original anchor tag, which is otherwise fine.Before:
After: