Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Image Cropper handle (focal point) #1021

Merged
merged 95 commits into from
Oct 16, 2024
Merged

Adjust Image Cropper handle (focal point) #1021

merged 95 commits into from
Oct 16, 2024
+203 −84

Commits on Nov 26, 2023

  1. Adjust Image Cropper focal point to be consistent with Color Area handle

    @bjarnef
    bjarnef committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    6d59028 View commit details
    Browse the repository at this point in the history

  2. Make focus point focusable via keyboard

    @bjarnef
    bjarnef committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    ca3474c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Update import of utils from uui

    @bjarnef
    bjarnef committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c2c7b48 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ebedf33 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b9de615 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:umbraco/Umbraco.CMS.Backoffice into… 

    … feature/image-cropper-handle
    @bjarnef
    bjarnef committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    dc3c532 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/image-cropper-handle' of github.com:bjarnef/Umb… 

    …raco.CMS.Backoffice into feature/image-cropper-handle
    @bjarnef
    bjarnef committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1683038 View commit details
    Browse the repository at this point in the history

  4. Make focal point accessible via keyboard

    @bjarnef
    bjarnef committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e9c7b2f View commit details
    Browse the repository at this point in the history

  5. Move logic to function

    @bjarnef
    bjarnef committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    00d6c72 View commit details
    Browse the repository at this point in the history

  6. Reset coords

    @bjarnef
    bjarnef committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    87eca87 View commit details
    Browse the repository at this point in the history

  7. Remove reset coords

    @bjarnef
    bjarnef committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    03a3a7e View commit details
    Browse the repository at this point in the history

  8. Reset coords if focal point is updated to center

    @bjarnef
    bjarnef committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    11666ac View commit details
    Browse the repository at this point in the history

  9. Format document

    @bjarnef
    bjarnef committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    5249f95 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Set focal point property instead

    @bjarnef
    bjarnef committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    03bcee2 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Merge branch 'main' of github.com:umbraco/Umbraco.CMS.Backoffice into… 

    … feature/image-cropper-handle

# Conflicts:
#	src/packages/media/media/components/input-image-cropper/image-cropper-focus-setter.element.ts
    @bjarnef
    bjarnef committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    61956d4 View commit details
    Browse the repository at this point in the history

  2. Formatting

    @bjarnef
    bjarnef committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    ef5fc6d View commit details
    Browse the repository at this point in the history

  3. Fix warnings

    @bjarnef
    bjarnef committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    86b8b3b View commit details
    Browse the repository at this point in the history

  4. Width and height

    @bjarnef
    bjarnef committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    6d9e3be View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Remove added outline so we can see when focal point has focus via key… 

    …board
    @bjarnef
    bjarnef committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    23ff2de View commit details
    Browse the repository at this point in the history

  2. Reset coords

    @bjarnef
    bjarnef committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a251fb4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    57b09e5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:umbraco/Umbraco.CMS.Backoffice into… 

    … feature/image-cropper-handle
    @bjarnef
    bjarnef committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    122ad4b View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @bjarnef
    bjarnef committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    42268ca View commit details
    Browse the repository at this point in the history

  6. Update import

    @bjarnef
    bjarnef committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    6a92562 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f3f7d06 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Feb 29, 2024
    Configuration menu
    Copy the full SHA
    00b7188 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Feb 29, 2024
    Configuration menu
    Copy the full SHA
    3988aaa View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    37ef47f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    ac1ab94 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Mar 3, 2024
    Configuration menu
    Copy the full SHA
    9731fc4 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6a83928 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    f068d07 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored May 14, 2024
    Configuration menu
    Copy the full SHA
    a8f354a View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored May 17, 2024
    Configuration menu
    Copy the full SHA
    ffcc397 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:umbraco/Umbraco.CMS.Backoffice into… 

    … feature/image-cropper-handle

# Conflicts:
#	src/packages/media/media/components/input-image-cropper/image-cropper-focus-setter.element.ts
    @bjarnef
    bjarnef committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6968e49 View commit details
    Browse the repository at this point in the history

  3. Cleanup

    @bjarnef
    bjarnef committed May 17, 2024
    Configuration menu
    Copy the full SHA
    75ac167 View commit details
    Browse the repository at this point in the history

  4. Use UmbChangeEvent

    @bjarnef
    bjarnef committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3e5a981 View commit details
    Browse the repository at this point in the history

  5. Adjust elements

    @bjarnef
    bjarnef committed May 17, 2024
    Configuration menu
    Copy the full SHA
    d47f4b1 View commit details
    Browse the repository at this point in the history

  6. Import drag for uui

    @bjarnef
    bjarnef committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f71a727 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Cleanup styling

    @bjarnef
    bjarnef committed May 20, 2024
    Configuration menu
    Copy the full SHA
    fe3a642 View commit details
    Browse the repository at this point in the history

  2. Cleanup

    @bjarnef
    bjarnef committed May 20, 2024
    Configuration menu
    Copy the full SHA
    72c6bba View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary events

    @bjarnef
    bjarnef committed May 20, 2024
    Configuration menu
    Copy the full SHA
    346f804 View commit details
    Browse the repository at this point in the history

  4. Container is HTMLElement

    @bjarnef
    bjarnef committed May 20, 2024
    Configuration menu
    Copy the full SHA
    d855dc0 View commit details
    Browse the repository at this point in the history

  5. Check focal point updated

    @bjarnef
    bjarnef committed May 20, 2024
    Configuration menu
    Copy the full SHA
    49a3b9a View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored May 23, 2024
    Configuration menu
    Copy the full SHA
    2a02dce View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Merge branch 'main' of github.com:umbraco/Umbraco.CMS.Backoffice into… 

    … feature/image-cropper-handle

# Conflicts:
#	src/packages/media/media/components/input-image-cropper/image-cropper-focus-setter.element.ts
    @bjarnef
    bjarnef committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a0d7b29 View commit details
    Browse the repository at this point in the history

  2. Fix conflicts after merge

    @bjarnef
    bjarnef committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    43af264 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    b8feef8 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ce6478d View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    113dbe7 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Null check

    @bjarnef
    bjarnef committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    dfd4902 View commit details
    Browse the repository at this point in the history

  2. Update correct element types

    @bjarnef
    bjarnef committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d7021a1 View commit details
    Browse the repository at this point in the history

  3. Revert to custom event

    @bjarnef
    bjarnef committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    57a0cfc View commit details
    Browse the repository at this point in the history

  4. Cleanup console

    @bjarnef
    bjarnef committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6b57d0b View commit details
    Browse the repository at this point in the history

  5. Don't hide overflow, so focal point is not cut off on edges on image

    @bjarnef
    bjarnef committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3cf4f00 View commit details
    Browse the repository at this point in the history

  6. Add margin top at actions so focal point doesn't overlap buttons

    @bjarnef
    bjarnef committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    fa84877 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ace53c4 View commit details
    Browse the repository at this point in the history

  2. Top margin at actions

    @bjarnef
    bjarnef committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    52a4c01 View commit details
    Browse the repository at this point in the history

  3. Crosshair cursor when focal point is not hidden

    @bjarnef
    bjarnef committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3b32ad6 View commit details
    Browse the repository at this point in the history

  4. Cancel update focal point

    @bjarnef
    bjarnef committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4a7bab7 View commit details
    Browse the repository at this point in the history

  5. Add move cursor to viewport image

    @bjarnef
    bjarnef committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    e8e839a View commit details
    Browse the repository at this point in the history

  6. Use crop label

    @bjarnef
    bjarnef committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    12418b7 View commit details
    Browse the repository at this point in the history

  7. Add missing label

    @bjarnef
    bjarnef committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4461e35 View commit details
    Browse the repository at this point in the history

  8. Disable draggable of image as in old backoffice

    @bjarnef
    bjarnef committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f32c600 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Fix previous merge conflicts

    @bjarnef
    bjarnef committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    fb7948d View commit details
    Browse the repository at this point in the history

  2. Update src/packages/media/media/components/input-image-cropper/image-… 

    …cropper-focus-setter.element.ts

Co-authored-by: Jacob Overgaard <[email protected]>
    @bjarnef @iOvergaard
    bjarnef and iOvergaard authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6f75128 View commit details
    Browse the repository at this point in the history

  3. Update src/packages/media/media/components/input-image-cropper/image-… 

    …cropper-focus-setter.element.ts

Co-authored-by: Jacob Overgaard <[email protected]>
    @bjarnef @iOvergaard
    bjarnef and iOvergaard authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    72bfa93 View commit details
    Browse the repository at this point in the history

  4. Update src/packages/media/media/components/input-image-cropper/image-… 

    …cropper-focus-setter.element.ts

Co-authored-by: Jacob Overgaard <[email protected]>
    @bjarnef @iOvergaard
    bjarnef and iOvergaard authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    dfef9ea View commit details
    Browse the repository at this point in the history

  5. Update src/packages/media/media/components/input-image-cropper/image-… 

    …cropper-focus-setter.element.ts

Co-authored-by: Jacob Overgaard <[email protected]>
    @bjarnef @iOvergaard
    bjarnef and iOvergaard authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    47a32aa View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    2c4de9e View commit details
    Browse the repository at this point in the history

  7. Remove disconnectedCallback

    @bjarnef
    bjarnef committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    4df432a View commit details
    Browse the repository at this point in the history

  8. Ignore in the debug element

    @bjarnef
    bjarnef committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    864395a View commit details
    Browse the repository at this point in the history

  9. Add custom event for focal point change

    @bjarnef
    bjarnef committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f1449dd View commit details
    Browse the repository at this point in the history

  10. Import type

    @bjarnef
    bjarnef committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    10a6251 View commit details
    Browse the repository at this point in the history

  11. Replace with UmbImageCropChangeEvent

    @bjarnef
    bjarnef committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    459665b View commit details
    Browse the repository at this point in the history

  12. Use UmbFocalPointModel

    @bjarnef
    bjarnef committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    952826c View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    eb30ac8 View commit details
    Browse the repository at this point in the history

  14. Move set focal pont style to setter

    @bjarnef
    bjarnef committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    e307bd4 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Update custom event name

    @bjarnef
    bjarnef committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    108c021 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Merge branch 'main' of github.com:umbraco/Umbraco.CMS.Backoffice into… 

    … feature/image-cropper-handle

# Conflicts:
#	src/packages/media/media/components/input-image-cropper/image-cropper-preview.element.ts
#	src/packages/media/media/components/input-image-cropper/types.ts
#	src/packages/media/media/property-editors/media-picker/index.ts
    @bjarnef
    bjarnef committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    e29c947 View commit details
    Browse the repository at this point in the history

  2. Localize focal point label

    @bjarnef
    bjarnef committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    a829ed6 View commit details
    Browse the repository at this point in the history

  3. Fix import of UmbFocalPointModel type

    @bjarnef
    bjarnef committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    ad19d24 View commit details
    Browse the repository at this point in the history

  4. Localize buttons

    @bjarnef
    bjarnef committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    9057fc4 View commit details
    Browse the repository at this point in the history

  5. Update labels

    @bjarnef
    bjarnef committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b426eb7 View commit details
    Browse the repository at this point in the history

  6. Combine imports

    @bjarnef
    bjarnef committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    09639de View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    bbc3b66 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    7133a06 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    9418110 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    a4121e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7e553ac View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    53cad7f View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3567f06 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ed30328 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @bjarnef
    bjarnef authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1d32afb View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'main' into feature/image-cropper-handle

    @iOvergaard
    iOvergaard authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2c1c9af View commit details
    Browse the repository at this point in the history