Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Relative time component #868

Draft
wants to merge 23 commits into
base: v1/contrib
Choose a base branch
from

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 24, 2024

Description

Add a relative time component as suggested in #143

I think uui-relative-time is a better name than the suggested uui-time-ago as it can both show time label for datetime in past and future.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef
Copy link
Contributor Author

bjarnef commented Jul 24, 2024

@iOvergaard @leekelleher I had a look at this based on the example mentioned here: #143 (comment)

We I used Umbraco's birthday, it seems odd Storybook set date to February 17th 🤷‍♂️

image

Anyway I like the options to show as datetime as past (time ago) or future (from now).

image

I think the getRelativeTimeString() function here may be useful as well:
https://x.com/Steve8708/status/1504131981444980739
https://gist.github.com/steve8708/ada9bff2600228789fce2fcc95427e39

Could we eventually add a language/locale switcher in Storybook something like this?
https://storybook.js.org/blog/internationalize-components-with-storybook/

Copy link

sonarcloud bot commented Aug 5, 2024

@EmanuelGustafzon
Copy link

Hi @bjarnef

Are you still working on this component?

@bjarnef
Copy link
Contributor Author

bjarnef commented Aug 15, 2024

@EmanuelGustafzon yes, it is still WIP.

It may need some input/feedback from Umbraco HQ how they want this to work.
I didn't think <uui-time-ago> was the best name as it is possible to show relative date/time in past and future, so <uui-relative-time> was a better name.

Perhaps @iOvergaard @nielslyngsoe or @leekelleher could try this out?

@EmanuelGustafzon
Copy link

Ok good to know, I started with the same issue but then I know you are on it!

@nielslyngsoe nielslyngsoe self-requested a review August 15, 2024 11:06
@nielslyngsoe
Copy link
Member

nielslyngsoe commented Aug 15, 2024

Hi @bjarnef

I love the name, so thanks for that input.

Is there anything specifically, that must be solved before this can be reviewed?

@nielslyngsoe
Copy link
Member

nielslyngsoe commented Aug 15, 2024

@bjarnef

I do get an React error in Storybook, is this something you also experience?
image

If so, is it something you need help to resolve?

@bjarnef
Copy link
Contributor Author

bjarnef commented Aug 15, 2024

@nielslyngsoe there's a few things to look at reported by Sonarcloud:
#868 (comment)

I haven't noticed that specific error, but could be related to something else perhaps? Does a clean npm i help.. @iOvergaard upgraded recently husky, not sure if that may cause the error?

Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

sonarcloud bot commented Nov 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants