-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Relative time component #868
base: v1/contrib
Are you sure you want to change the base?
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
@iOvergaard @leekelleher I had a look at this based on the example mentioned here: #143 (comment) We I used Umbraco's birthday, it seems odd Storybook set date to February 17th 🤷♂️ Anyway I like the options to show as datetime as I think the Could we eventually add a language/locale switcher in Storybook something like this? |
Quality Gate passedIssues Measures |
Hi @bjarnef Are you still working on this component? |
@EmanuelGustafzon yes, it is still WIP. It may need some input/feedback from Umbraco HQ how they want this to work. Perhaps @iOvergaard @nielslyngsoe or @leekelleher could try this out? |
Ok good to know, I started with the same issue but then I know you are on it! |
Hi @bjarnef I love the name, so thanks for that input. Is there anything specifically, that must be solved before this can be reviewed? |
@nielslyngsoe there's a few things to look at reported by Sonarcloud: I haven't noticed that specific error, but could be related to something else perhaps? Does a clean |
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
Description
Add a relative time component as suggested in #143
I think
uui-relative-time
is a better name than the suggesteduui-time-ago
as it can both show time label for datetime in past and future.Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist