-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Readonly state for uui-color-swatch #916
Feat: Readonly state for uui-color-swatch #916
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
This attribute is allowed only on selected aria roles and button is not one of them
Quality Gate passedIssues Measures |
Description
This PR adds a readonly state for the
uui-color-swatch
component. It will ensure that the swatch can't be selected.Fixes #900
Changed to use native
disabled
attribute on underlying<button>
element instead ofaria-disabled
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-disabled andaria-readonly
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-readonly as button element doesn't havereadonly
state.Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist