Ensure keydown doesn't trigger click event as well in SelectableMixin #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… which trigger select + deselect.
Description
This PR fixes #654
When hitting space key e.g. at
uui-color-swatch
it furthermore triggered click event. So it selected the element, but deselected it immediately after.I have tested that selection + deselection both work using keydown and click event.
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
chrome_2JriAQbCXV.mp4
Checklist