Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
리뷰 이미지 업로드 로직을 로컬 저장소에서 S3 저장 방식으로 전환
Fixes #115
⚙️ Type
📂 Summary of Changes
src/s3.upload.js: deleteFromS3 유틸리티 함수 추가src/review/controller/review.controller.js: 업로드 실패 예외 처리 추가src/review/service/review.service.js: S3 업로드로 변경 및 삭제 처리 추가, 이미지 형식 검증 추가👀 To Reviewer
테스트 결과
uploadToS3()업로드 유틸리티 함수를 사용하였으며, 퍼블릭 URL에서 Key 값을 추출한 뒤 S3에서 해당 객체를 삭제하는deleteFromS3()유틸리티 함수를 추가하였습니다!.jpg|.jpeg) 표기 차이는 따로 변환하지 않고 그대로 두었습니다✅ PR Checklist