Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to run all benchmarks with docker #43

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Add script to run all benchmarks with docker #43

merged 2 commits into from
Apr 8, 2022

Conversation

vypxl
Copy link
Collaborator

@vypxl vypxl commented Apr 8, 2022 •
edited
Loading

Closes #24

@vypxl vypxl self-assigned this Apr 8, 2022
@vypxl vypxl added the enhancement New feature or request label Apr 8, 2022
@TecTrixer TecTrixer self-requested a review April 8, 2022 15:42
@TecTrixer
Copy link
Collaborator

The benchmark takes forever and also fails sometimes. Please make a better, more stable version with a lower benchmark count

@vypxl
Copy link
Collaborator Author

vypxl commented Apr 8, 2022

That is not a problem with this script, but rather our amazing client and servers.

@umgefahren
Copy link
Owner

If you want the issues in the client resolved, please comment on #57.

TecTrixer
TecTrixer approved these changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@TecTrixer TecTrixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for now, although this should not be the final version

@umgefahren
Copy link
Owner

We'll rewrite some stuff anyway for running on different servers later.

Zollerboy1
Zollerboy1 approved these changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@Zollerboy1 Zollerboy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@vypxl vypxl merged commit 1405be4 into main Apr 8, 2022
@vypxl vypxl deleted the run-benchmarks-script branch April 8, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zollerboy1 Zollerboy1 Zollerboy1 approved these changes

@TecTrixer TecTrixer TecTrixer approved these changes

@umgefahren umgefahren umgefahren approved these changes

Assignees

@vypxl vypxl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate benchmark result aggregation
4 participants
@vypxl @TecTrixer @umgefahren @Zollerboy1