forked from microsoft/promptflow
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[promptflow] Bump SQLAlchemy to 2.x (microsoft#1254)
# Description Bump `SQLAlchemy` to 2.x. Previously, we have limitation <2.0.0 because another dependency `dataset` has strict rule on that. However, we don't have code path requiring `dataset` any more (related feature is deprecated). So in this PR, remove related code (`LocalCacheStorage`), and `dataset` in `setup.py`, then bump `SQLAlchemy` version to allow 2.x. Verification workflows: SQLAlchemy 2.x: <https://github.com/microsoft/promptflow/actions/runs/6978087648/job/18988891341?pr=1254#step:10:502> - Executor - UT: <https://github.com/microsoft/promptflow/actions/runs/6978087648> - E2E: <https://github.com/microsoft/promptflow/actions/runs/6978087652> - SDK/CLI: <https://github.com/microsoft/promptflow/actions/runs/6978087670> # All Promptflow Contribution checklist: - [x] **The pull request does not introduce [breaking changes].** - [x] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [x] Title of the pull request is clear and informative. - [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [x] Pull request includes test coverage for the included changes.
- Loading branch information
1 parent
81b6e99
commit 9781c60
Showing
5 changed files
with
3 additions
and
228 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters