Skip to content

Commit

Permalink
Merge pull request #280 from unboxed/fix-debian-versions
Browse files Browse the repository at this point in the history
Fix dockerfiles still using Debian bullseye (oldstable)
  • Loading branch information
benjamineskola authored Jan 14, 2025
2 parents 4555819 + ea0b1b4 commit 0898d6e
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 13 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/deploy-environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ permissions:
jobs:
build-image:
name: Create and push docker image to ECR for ${{ inputs.environment-name }}
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
environment: ${{ inputs.environment-name }}

steps:
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
deploy-services:
name: Deploy services to ${{ inputs.environment-name }}
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: [build-image]
strategy:
matrix:
Expand Down Expand Up @@ -144,7 +144,7 @@ jobs:

tag-release:
name: Tag release
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: [build-image]
permissions:
contents: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ on:
jobs:
linters:
name: Linters
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
env:
BUNDLE_WITHOUT: development

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ on:
jobs:
tests:
name: ${{ inputs.name }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

services:
postgres:
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile.production
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Base image for all other build stages
ARG RUBY_VERSION=3.4.1

FROM ruby:$RUBY_VERSION-slim-bullseye AS base_image
FROM ruby:$RUBY_VERSION-slim-bookworm AS base_image

# Run security updates and install apt-utils curl and locales
RUN bash -c "export DEBIAN_FRONTEND=noninteractive && \
Expand Down Expand Up @@ -46,11 +46,11 @@ FROM build_image AS gems

# Required system packages

# Run security updates, install libpq-dev
# Run security updates, install libpq-dev and libyaml-dev
RUN bash -c "export DEBIAN_FRONTEND=noninteractive && \
apt-get update -qq && \
apt-get upgrade -y && \
apt-get install -y libpq-dev && \
apt-get install -y libpq-dev libyaml-dev && \
apt-get clean && \
rm -rf /var/lib/apt/lists/*"

Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
services:
db:
image: postgres:14-bullseye
image: postgres:14-bookworm
volumes:
- type: volume
source: db
Expand Down
8 changes: 4 additions & 4 deletions docker/ruby/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
ARG RUBY_VERSION=3.4.1

FROM ruby:$RUBY_VERSION-bullseye
FROM ruby:$RUBY_VERSION-slim-bookworm

ENV BUNDLE_PATH=/home/rails/bundle

# Run security updates and install apt-utils curl and locales
RUN bash -c "export DEBIAN_FRONTEND=noninteractive && \
apt-get update -qq && \
echo 'en_US.UTF-8 UTF-8' > /etc/locale.gen && \
apt-get install -y apt-utils curl locales && \
apt-get install -y apt-utils curl locales gnupg && \
apt-get upgrade -y && apt-get clean"

# Install PostgreSQL client
RUN bash -c "echo 'deb http://apt.postgresql.org/pub/repos/apt/ bullseye-pgdg main' \
RUN bash -c "echo 'deb http://apt.postgresql.org/pub/repos/apt/ bookworm-pgdg main' \
> /etc/apt/sources.list.d/pgdg.list && \
wget -q -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc \
curl -sS https://www.postgresql.org/media/keys/ACCC4CF8.asc \
| apt-key add - && apt-get update && \
apt-get install -y --no-install-recommends postgresql-client-14"

Expand Down

0 comments on commit 0898d6e

Please sign in to comment.