-
Notifications
You must be signed in to change notification settings - Fork 20
feat(coworking)!: room reservations enhancements and group room reservations #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Start to create a room availability API to power the new frontend.
Begins to work on the UI for the room reservations grid using the newly created API.
Upgrades to Angular v19 in preparation for upgrading Material.
Upgrades to Angular Material v19 in preparation for upgrading to v20.
Upgrades to Angular v20 in prepration of upgrading Material.
Upgrades to Angular Material v20.
There were some changes from the upgrade that caused errors.
|
This is looking awesome! Couple of quick questions:
|
|
Thank you @KrisJordan!
|
Adds a tooltip to display the number of remaining required users for a reservation to be possible.
The office hour policy also now blocks the ability to select a reservation time slot.
Ensure that bypassing the frontend and calling the draft reservation API directly for a room occupied by office hours fails.
Updates the package lock to include the new dependencies, including Tailwind.
Refactors the coworking policy code to ensure that instructors and users have separate coworking policies. This can ultimately be extended so that ambassadors, etc have different policies.
When office hours occupy a room, a room is marked now as "unavailable" rather than "reserved".
|
@KrisJordan, I modified the current implementation to add a new policy for instructors (separate from the user policy). The Also, want to ask a bit more clarity (to refresh my memory) on what we decided regarding office hours. I have been thinking a bit more about the refactor to a state where singular office hours events (not recurring) creates a reservation for that time in the room. I feel like there may be edge cases, particularly when sharing rooms, that might increase complexity for both a backend refactor and also on the instructor side. Given the current use case right now, I am wondering if the current implementation is fine (along with bringing back relying on the The recent modifications change the functionality so that instructors can reserve more weeks in advance and have no hours limits, which should suffice for COMP211's purposes. I am assuming the onus being on instructors not to abuse the system will be better / easier to enforce than all staff (including UTAs)? If this sounds good, the current implementation here may be "good enough" for the immediate concerns (for the small edge case of instructor room reservations) and include a significant UI improvement for all users on the site, which also unblocks the Tailwind migration! As we were brainstorming, the reservations for OH could be shifted to a 423/523 project! |
Allow overlapping room reservations for instructor purposes.
This PR makes major changes to the room reservation feature in the XL site that adds group reservations, helps instructors with reserving rooms, helps administrators manage operating hours, and updates the UI to conform to Material standards. The application is also upgraded to Angular v20 and begins an incremental adoption of TailwindCSS.
Features
The following features have been added in this update:
ceil(capacity / 2)as recommended in the final project idea for COMP423. The maximum number of students per reservation is based on the capacity of the room. Any group member is able to cancel the reservation.General Project Changes
Future Work