-
Notifications
You must be signed in to change notification settings - Fork 20
Applicant Flagging Feature #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
punjarmaan
wants to merge
14
commits into
unc-csxl:main
Choose a base branch
from
jeff-zhang12:applicant-flagging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that optimistic updating on flagging is rolled back upon an error. In addition, hard-coded styles are removed and replaced with material colors.
ajaygandecha
reviewed
Dec 1, 2025
Member
ajaygandecha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello team, great work on this! LGTM, very nice work on the design here - I am going to request a final review from @KrisJordan to approve and ensure the migration is setup up correctly, then we can merge.
I added a quick commit for two things:
- The optimistic updating logic for the flagging UI works well - but if there is an error, we need to roll back the change. I added quick error handling for this (and a small refactor to add a snackbar alert if an error occurs when updating, which is helpful across to the entire feature)
- I switched the hard-coded hex values for the flag icon to use the colors generated by material's CSS functions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Added flagging feature to allow HR/Coordinator to flag hiring assignments on the onboarding page
Changes:
Screen.Recording.2025-11-20.at.3.53.41.PM.mov