Ss4 upgrade #56
Ss4 upgrade #56
Conversation
|
lol I did this in #57 too. |
unclecheese
left a comment
unclecheese
left a comment
There was a problem hiding this comment.
Nice work. Thanks for taking this on. Happy to merge it if we can just get the Requirements calls sorted. @sminnee ??
_config.php
Outdated
| <?php | ||
|
|
||
| define('BOOTSTRAP_FORMS_DIR',basename(dirname(__FILE__))); | ||
| define('BOOTSTRAP_FORMS_DIR','vendor/unclecheese/bootstrap-forms/'); |
There was a problem hiding this comment.
Don't need this defined anymore. Use module references in Requirements:: calls.
| "javascript", | ||
| "css" | ||
| ] | ||
| } |
src/BootstrapButtonGroupField.php
Outdated
|
|
||
| public function Field($attributes = array ()) | ||
| { | ||
| Requirements::javascript(BOOTSTRAP_FORMS_DIR."/javascript/bootstrap_forms.js"); |
There was a problem hiding this comment.
Use module reference here: unclecheese/boostrapforms: file.js`
| Requirements::javascript(BOOTSTRAP_FORMS_DIR."/javascript/bootstrap-select/js/bootstrap-select.min.js"); | ||
| Requirements::javascript(BOOTSTRAP_FORMS_DIR."/javascript/bootstrap-select/js/i18n/defaults-{$current_locale}.js"); | ||
| Requirements::css(BOOTSTRAP_FORMS_DIR."/javascript/bootstrap-select/css/bootstrap-select.min.css"); | ||
| } |
|
I've asked @scott-nz for commit rights to his fork so that I can make the ^ changes. |
|
How's that @unclecheese ? |
|
This has an issue in that bootstrap forms are applied to the CMS as well. I'm not sure if there's a way of disabling all the special onBeforeRender hooks for fields that aren't part of a BootstrapForm? Perhaps onBeforeRender should be moved to a per-field
|
3 participants
SilverStripe 4 upgrade.